Repository navigation
Fail a hung test after three minutes in CI - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twice today, the macOS job stopped in the middle of the browser tests and ran until it was cancelled. Chrome was still running, and each time it stopped in a different test file. The log can't show which test hung, because the output of later files waits for the one that hangs.
CI now runs the tests with a three minute limit per test, so a hang fails with the name of the test. Tests that need longer still set their own limit.
--test-force-exitends each file once its tests are done, even if a browser process is left behind. The job also stops after 25 minutes. A normal run takes 2 to 4 minutes.npm teststays as it was for local runs.