Skip to content

Update README for station-chart-datum-only heights - #13

Merged
vinc3m1 merged 2 commits into
mainfrom
claude/bay-area-tides-offset-mpim28
Jul 19, 2026
Merged

vinc3m1 merged 2 commits into
mainfrom
claude/bay-area-tides-offset-mpim28

Conversation

@vinc3m1

@vinc3m1 vinc3m1 commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Follow-up to #12, addressing review feedback: removing the datum switcher left the README describing a workflow that no longer exists.

  • Dropped "chart datum" from the preference lists in What it does and Your data (it's no longer a persisted setting).
  • Reworded the How to use it step for ⓘ Source & accuracy — it now shows the station's chart datum and reference levels read-only instead of offering a switcher.
  • Added a paragraph to A note on accuracy stating the new behavior: heights are always shown above each station's own chart datum (MLLW for NOAA, LAT for TICON), matching its published tide tables, with the datums table on the Source & accuracy page for anyone who needs to convert.

Docs-only change; no code touched.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Bsh1A5WLRb9xhiGNxUvs8p


Generated by Claude Code

The datum switcher was removed in #12 (a global override mislabeled
stations lacking the chosen datum key), but the README still advertised
chart datum as a switchable, persisted preference. Drop it from the
preference lists, reword the Source & accuracy step, and document the
new behavior: heights are always above the station's own chart datum,
matching its published tide tables, with the reference levels listed
read-only on the Source & accuracy page.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Bsh1A5WLRb9xhiGNxUvs8p

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f9122fb62

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md Outdated
Comment on lines +49 to +50
numbers line up with local tables. There's no datum switcher; the Source & accuracy page
lists the station's reference levels for anyone who needs to convert.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Qualify reference levels for datum-less stations

For datum-less subordinate stations such as NOAA 9414849, station.datums is empty, so the {#if datums.length} guard in src/routes/Detail.svelte suppresses the reference-level table entirely. The new text therefore directs affected users to conversion information that the Source & accuracy page does not provide; qualify this promise as applying only when reference levels are available.

Useful? React with 👍 / 👎.

Subordinate stations predicted by offsets (e.g. NOAA 9414849) ship no
datums table, so the Source & accuracy page has no reference levels to
list — don't promise them unconditionally.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Bsh1A5WLRb9xhiGNxUvs8p
@vinc3m1
vinc3m1 enabled auto-merge (squash) July 19, 2026 17:28
@vinc3m1
vinc3m1 merged commit dbf9745 into main Jul 19, 2026
2 checks passed
@vinc3m1
vinc3m1 deleted the claude/bay-area-tides-offset-mpim28 branch July 19, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants