Backport: [v6.0] fix(react): preserve chat when id is undefined#16830
Open
github-actions[bot] wants to merge 1 commit into
Open
Backport: [v6.0] fix(react): preserve chat when id is undefined#16830github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Backport of #16484 to `release-v6.0`. Passing an explicitly-undefined `id` to `useChat` recreated the internal `Chat` instance on every render (because the `id` key exists in options while the generated chat ID never equals `undefined`), wiping messages and stream state; the fix changes the recreate guard to only apply when the provided `id` is non-nullish. The `use-chat.ts` guard change and the changeset applied cleanly; the regression test from the original commit conflicted only because `main`'s test file wraps everything in an outer `describe('use-chat')` block that does not exist on v6, so the new `describe('undefined id')` block was re-indented to match v6's flat test file structure with no semantic changes. Part of the v6.0 backport tracking issue #16767.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #16797 to the release-v5.0 branch. FYI @gr2m