[v6.0] fix(ai): enforce timeout.stepMs for the whole step in streamText#16801
Merged
Conversation
Manual backport of #15840 to release-v6.0: the step/chunk timers were disarmed in a finally block as soon as step setup returned, so timeout.stepMs never fired on stalled streams. Keep the timers armed past setup, clear them via the merged abort signal, and only clear eagerly when setup itself throws. Tests adapted to v6 (MockLanguageModelV3, stepCountIs, no TimeoutError abort reason on v6). (cherry picked from commit eeefc3f649b58e93df67f925e40be6b830992051)
Contributor
|
|
Contributor
|
🚀 Published in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #15840 to
release-v6.0. The stream-text.ts internals diverged between v6 and main, so the fix was ported by hand: keep the step/chunk timers armed after step setup returns (they were disarmed in afinallyimmediately), clear them via the merged abort signal, and clear eagerly only when setup throws. Tests adapted to v6 idioms (MockLanguageModelV3,stepCountIs, noTimeoutErrorabort reason since #14943 is not on v6 yet). Full stream-text suite passes locally (349/349).Part of the v6.0 backport tracking issue #16767.