Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global installs currently succeed into inactive directories when OpenClaw, Hermes Agent or Qwen Code runs with an alternate home/profile. For example,
QWEN_HOME=/tmp/qwen-work skills add ./skill -a qwen-code -g -ywrites to~/.qwen/skillsrather than/tmp/qwen-work/skills.Resolve the active directories in
src/agents.ts, where installation, detection, listing and removal already obtain their paths:OPENCLAW_STATE_DIRandOPENCLAW_HOME, including leading~and invocation-relative paths. Explicit state directories take precedence over existing default/legacy roots; retain legacy discovery when there is no state override.HERMES_DATA_DIR_SUFFIX, the WindowsLOCALAPPDATAdefault, and explicitHERMES_HOMEprecedence with home/environment expansion.QWEN_HOMEusing Qwen's tilde/relative-path semantics, without applying another client's trimming or environment expansion rules.Detection checks the same resolved directory used by the other commands. Document the overrides and isolate them in the CLI test environment. Existing installations are not automatically moved or deleted.
Closes #2450.
Validation
git diff --checkpass.npx --package <tarball> skills. 11 isolated scenarios pass add, repeat, list and remove, installing all six files ofreverse-engineer-anythingbyte-for-byte. These cover all three agents' defaults plus absolute overrides, relative paths, OpenClaw home expansion, Hermes suffix/environment expansion and Qwen tilde expansion.Windows defaults are covered by resolver tests; I have not run a native Windows session or a model-backed harness session.
Upstream contracts checked