Skip to content

fix: preserve URL skill filters and restore nested Git skills - #2435

Open
quuu wants to merge 1 commit into
mainfrom
fix/source-filter-lock-restore
Open

quuu wants to merge 1 commit into
mainfrom
fix/source-filter-lock-restore

Conversation

@quuu

@quuu quuu commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #2426. Fixes #2429.

+#ref@skill survives GitHub/GitLab/SSH URL parsing
+lock restore uses update's full-depth rule for unaddressable nested Git paths

Evidence

Before: 12 new URL/restore regressions failed on main. After: 154 focused tests pass; manual URL parsing and built CLI install/delete/restore pass. Type check, formatting and build pass. Full suite: 954 pass, one TTY test fails identically on unchanged main.

Merge Danger

Two-way door; scope is source parsing and project lock restore. Full-depth discovery stays limited to sources whose locked path cannot be appended to the clone URL. Existing hash formats are unchanged.

@vercel-agent-factory vercel-agent-factory Bot added bug Something isn't working triage:bug-fix Factory triage found an evidence-backed bug-fix candidate for maintainer review labels Oct 8, 2026
@vercel-agent-factory

Copy link
Copy Markdown

@quuu — bug-fix candidate.

  • Fix: Restores skill-name filters dropped during GitHub/GitLab/SSH URL parsing, and fixes lock restore for nested Git skills needing full-depth search.
  • Tests: Added regression coverage in source-parser.test.ts for fragment skill filters.
  • CI: pending (head ec28733f).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working triage:bug-fix Factory triage found an evidence-backed bug-fix candidate for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Lock restore cannot find nested GitLab skills installed with --full-depth [Bug]: Full GitHub and GitLab URLs drop the #ref@skill filter

1 participant