Repository navigation
fix: recognize BOM-prefixed skill frontmatter - #2421
Merged
Merged
Conversation
|
@quuu — bug-fix candidate.
|
6639835
reviewed
Oct 8, 2026
6639835
left a comment
There was a problem hiding this comment.
Reviewed the frontmatter matcher and parser/discovery tests at e0498a5. The optional U+FEFF remains anchored immediately before the YAML delimiter, preserving LF/CRLF and YAML-only behavior. Unmatched content remains unchanged; discovery retains rawContent. Tests cover BOM/no BOM, both newline styles, unsupported JavaScript headers, and text without frontmatter. No actionable issue found. Static review only; Vitest and the CLI were not run.
quuu
force-pushed
the
codex/skill-frontmatter-bom
branch
from
October 8, 2026 17:00
e0498a5 to
97640fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid SKILL.md files saved with a UTF-8 BOM were skipped as missing name and description. Accept an optional leading BOM before the YAML delimiter; preserve raw content and the YAML-only frontmatter boundary.
Four regression cases fail before the fix. All 59 focused parser/discovery tests and TypeScript pass after it, and a manual
skills add <local-dir> --listdiscovers the BOM-prefixed skill. Coverage includes LF/CRLF files and rejection of JavaScript frontmatter.