Skip to content

fix: recognize BOM-prefixed skill frontmatter - #2421

Merged
quuu merged 1 commit into
mainfrom
codex/skill-frontmatter-bom
Oct 8, 2026
Merged

quuu merged 1 commit into
mainfrom
codex/skill-frontmatter-bom

Conversation

@quuu

@quuu quuu commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Valid SKILL.md files saved with a UTF-8 BOM were skipped as missing name and description. Accept an optional leading BOM before the YAML delimiter; preserve raw content and the YAML-only frontmatter boundary.

Four regression cases fail before the fix. All 59 focused parser/discovery tests and TypeScript pass after it, and a manual skills add <local-dir> --list discovers the BOM-prefixed skill. Coverage includes LF/CRLF files and rejection of JavaScript frontmatter.

@vercel-agent-factory vercel-agent-factory Bot added bug Something isn't working triage:bug-fix Factory triage found an evidence-backed bug-fix candidate for maintainer review labels Oct 7, 2026
@vercel-agent-factory

Copy link
Copy Markdown

@quuu — bug-fix candidate.

  • Fix: BOM-prefixed SKILL.md files were skipped as missing name and description.
  • Tests: regression coverage in src/frontmatter.test.ts for LF/CRLF, BOM, and JS-frontmatter rejection.
  • CI: in progress at time of review (head e0498a5f).

@6639835 6639835 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the frontmatter matcher and parser/discovery tests at e0498a5. The optional U+FEFF remains anchored immediately before the YAML delimiter, preserving LF/CRLF and YAML-only behavior. Unmatched content remains unchanged; discovery retains rawContent. Tests cover BOM/no BOM, both newline styles, unsupported JavaScript headers, and text without frontmatter. No actionable issue found. Static review only; Vitest and the CLI were not run.

@quuu
quuu force-pushed the codex/skill-frontmatter-bom branch from e0498a5 to 97640fb Compare October 8, 2026 17:00
@quuu
quuu merged commit 2a7dc2a into main Oct 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working triage:bug-fix Factory triage found an evidence-backed bug-fix candidate for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants