Repository navigation
fix(update): honor locked paths with mirrored skills - #2231
Merged
gr2m merged 3 commits intoOct 9, 2026
Merged
Conversation
|
Independently reviewed commit 3e7fa9b with Codex assistance. Reproduced the locked-path ambiguity in the base resolver and verified that this change resolves it for path-addressable sources. Also checked that generic Git sources and missing locked paths with multiple candidates remain blocked. On macOS with Node 22.22.3, all 64 tests across skill-relocation, update, and update-source passed, as did type-checking, the build, and formatting checks on the changed files. I did not run the full suite or a live installed-skill update. No actionable findings in this scoped review. |
gr2m
approved these changes
Oct 9, 2026
gr2m
force-pushed
the
fix/locked-skill-path-update
branch
from
October 9, 2026 15:53
4e2f74a to
7ee0191
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
skills updateskipping a skill when its locked path still exists but the upstream repository also contains same-name mirrors.skillPathdisambiguate only when the source installer can target that exact subpath.This is intentionally narrower than simply moving the exact-path check before the ambiguity check: that unconditional change could reinstall the wrong copy for generic Git sources.
Tests
npx -y node@22.20.0 node_modules/vitest/vitest.mjs src/skill-relocation.test.ts tests/update.test.ts --run— 36 passedpnpm type-check— passedGitCloneError, anddist.test.tsinvoking the machine's Node 22.15 instead of the required Node >=22.20Fixes #2227
Fixes vercel/ai#22399
AI assistance disclosure
This contribution was developed with Codex assistance, including repository analysis, implementation, tests, and PR drafting, under Yuzhang Zhong's direction.