Repository navigation
Conversation
The steered stops, the turn-end lease release and the unpublished tty close each had their own copy of the retry loop for a request the busy terminal client refuses: the backoff, the exit check and the trace lines. One retryWhileBusy loop now runs all three. A pure busyRetryDelayMs gives the wait before each run, and each request keeps only its own run in a small runner type. The waits, the attempt count and the exit check do not change. The trace lines keep their wording, with two fixes: - The graceful stop's busy give-up no longer says dropped=background_command_stop, since the forced stop still runs. dropped= now appears once, from logDroppedStop, when the forced stop gives up or process exit cuts the stop short. - A stop that exit cuts short logs "gave up ... reason=runtime_stopping" like the lease release and the unpublished close, in place of "retry cut short". New tests cover the retry plan, the give-up trace lines, and process exit during a busy retry of the lease release and of the unpublished close, which end at once and log their dropped= line.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retryWhileBusyloop for a request the busy terminal client refuses. It owns the backoff, the exit check and the trace lines. The waits, attempt count and exit check are unchanged, andbusyRetryDelayMsholds the retry plan as a pure function.dropped=background_command_stopis written once per command left running: when the forced stop gives up or process exit cuts the stop short. The graceful stop's busy give-up no longer carries it, since the forced stop still runs.gave up ... reason=runtime_stopping, the same as the lease release and the unpublished close.