Repository navigation
Say when transcript drops and block appends run on a copy - #2203
Merged
Merged
Conversation
- The doc comments on the transcript drop and the table, code-block, and rule appends now say that the copy-and-commit path applies to a runtime with a `transcript_commit_state`. No behavior changes.
fazxes
marked this pull request as ready for review
November 22, 2026 20:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dropEntriesAtomic,dropEntries,appendAssistantBlockInPlace, andappendAssistantBlockAtomicnow say that the copy-and-commit path applies to a runtime with atranscript_commit_state, which is the only path today's callers take. Comments only; no behavior changes.Follow-up to #2171 and #2187, from their ship-gate notes.
The factory check reports transcript_paint and frozen_prefix as reached, because store.zig changed. Each passed one short round (
python3 -m scripts.fuzz_nightly run --target <name> --budget-seconds 60) on this head with no crash, failed law, or hang.