Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reading more of earlier saved outputs made a group tell the wrong story:
read_tool_resultcall as a search. A read of more of a saved output, by a byte range or from its start, now counts as reading more output (● Read files, read more output). A read withqueryorsearchstill searches.Read more output from zig build). The name comes from the call that saved the output, which the row finds by the handle the read names. When no call in the transcript saved it, the row takes the name from core's text, unless core cut that text short.Only the compact view changes. Core's status text, Ctrl+O, ACP and
fx askstay as they were.Tests
main, where it shows the● Searchedheader and the two full-path rows above.tests/e2e/tui-gateway-stream-lifecycle.test.tsreads two large files by long absolute paths, then reads more of both saved outputs. It fails on amainbuild and passes with the change.zig build testpass in the sandbox except the known environment failures (read-only files and blobs,web_fetch_artifacts, the capture deadline,change_trackerundo).tui-gateway-stream-lifecycle102/102,tui-tool-story15/15,tui-terminal-tool19/19,tui-command-permissions67/67 andtui-resume93/93 pass in the sandbox (onetui-resumecase failed once when its tmux server exited during setup, and passed alone).