Repository navigation
Conversation
Twenty calls in twelve files still used declarations Zig 0.17 deprecates, which AGENTS.md says fx does not use: std.fmt.allocPrint and bufPrint, std.mem.indexOf, std.StaticBitSet, and std.mem.copyForwards. Each is now the declaration it forwards to (Allocator.print, std.mem.print, std.mem.find, std.bit_set.Static), and the one copyForwards is a @memmove between slices of the same length.
capture_retention.zig started using std.StringArrayHashMapUnmanaged, which Zig 0.17 deprecates as an alias of std.array_hash_map.String. Use the name it forwards to.
fazxes
force-pushed
the
fazxes/zig-deprecated-calls
branch
from
November 22, 2026 20:54
b926eb2 to
c61f45c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdsays fx does not use them, and they had grown back.std.fmt.allocPrintbecomesAllocator.print,std.fmt.bufPrintbecomesstd.mem.print,std.mem.indexOfbecomesstd.mem.find,std.StaticBitSetbecomesstd.bit_set.Static, andstd.StringArrayHashMapUnmanagedbecomesstd.array_hash_map.String. Each is the declaration the old name forwards to, so behavior does not change.std.mem.copyForwardsintranscript_window_shell.zigbecomes@memmovebetween slices of the same length (items[0..rest.len]andrest).Testing
python3 .fx/skills/zig/scripts/check_deprecated.py src: 0 deprecated, down from 21.zig fmt --check src/: clean.zig buildpasses, andzig build testfails only the sandbox's known read-only and permission tests, the same set as onmain. None is in a changed file.