fix(embed): distinguish omitted and empty LLM keys - #3359
Open
Sanderhoff-alt wants to merge 1 commit into
Open
Conversation
HindsightEmbedded previously defaulted llm_api_key to an empty string and always forwarded it to the daemon. Omitting the argument therefore replaced a valid key inherited from the parent environment or profile. Use None as the default and omit the config entry only in that case. Keep an explicit empty string as an override, so local LLM services can still run without authentication. Add regression coverage for omitted, empty, and non-empty keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HindsightEmbedded.llm_api_keytoNoneProblem
HindsightEmbeddedpreviously defaultedllm_api_keyto an empty string and always forwarded it to the daemon. Constructing the client without a key could therefore overwrite a valid key inherited from the parent environment or the profile.envfile.Using
Nonefor the omitted case distinguishes inheritance from an explicitly empty key while keeping the existing daemon behavior unchanged.Fixes #3253.
Testing
uv run pytest tests/test_embedded_namespaces.py -quv run pytest tests/test_profile_daemon_config.py -q./scripts/hooks/lint.sh