fix(ollama): support gpt-oss thinking parameter - #3263
Open
goutamsidharth287 wants to merge 3 commits into
Open
Conversation
Use a low thinking level for gpt-oss models while preserving the existing behavior for other models.
Add regression coverage for model-specific Ollama think parameters and structured output.
Mock the async Ollama client context used by the native structured-output path.
Collaborator
|
Thanks for catching #3246! I opened #3344 as an alternative approach. Instead of the model-name heuristic ( Proposing #3344 supersede this one — but the fix is entirely thanks to your diagnosis here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Ollama native structured-output requests for gpt-oss models.
Previously,
thinkwas hardcoded toFalse, which causes structuredfact extraction to fail with gpt-oss models.
This change uses
think="low"for gpt-oss models while preservingthe existing
think=Falsebehavior for other Ollama reasoning models.Testing
thinkparameter for both gpt-oss and non-gpt-oss models.Fixes #3246