Skip to content

ci: run rosetta e2e tests with test:e2e - #1696

Merged
libotony merged 1 commit into
masterfrom
pedro/ci-rosetta-test-e2e
Nov 3, 2026
Merged

libotony merged 1 commit into
masterfrom
pedro/ci-rosetta-test-e2e

Conversation

@otherview

Copy link
Copy Markdown
Member

Description

The Rosetta e2e job fails on every PR and master push since vechain/rosetta#98 (merged 2026-10-30). That PR removed the test:e2e:custom npm script, and this workflow calls it:

npm error Missing script: "test:e2e:custom"

This PR calls npm run test:e2e instead, as rosetta's own CI does.

  • test:e2e:custom was TEST_NETWORK=custom jest. After "No Internet access" error on IOS app #98, jest's globalSetup starts Rosetta with thor solo and sets the network to custom itself.
  • The job still tests the thor binary from the PR. globalSetup runs docker compose in the rosetta directory, so it merges our docker-compose.override.yml (the thor-builder stage). It also reuses the image from the docker compose build step, because the image now has a fixed name (vechain-rosetta).

Type of change

  • CI fix

How Has This Been Tested?

  • The Rosetta e2e job on this PR.

vechain/rosetta#98 removed the test:e2e:custom script. Its jest
globalSetup now starts Rosetta with thor solo on the custom network,
so test:e2e replaces it.
@otherview
otherview requested a review from a team as a code owner November 2, 2026 15:07
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@libotony
libotony merged commit ec6d7c0 into master Nov 3, 2026
36 checks passed
@libotony
libotony deleted the pedro/ci-rosetta-test-e2e branch November 3, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants