MSVC profiles fine-tuning and small pipeline improvement#39
Merged
Conversation
kambala-decapitator
force-pushed
the
msvc-profile-improve
branch
from
087f5bc to
9d51400
Compare
fixes passing `None` to ignore Lua building
kambala-decapitator
force-pushed
the
msvc-profile-improve
branch
from
9d51400 to
ad0983a
Compare
…ne of our profiles
kambala-decapitator
force-pushed
the
msvc-profile-improve
branch
from
ad0983a to
af21841
Compare
1.6 doesn't build for Windows ARM
Collaborator
Author
|
@GeorgeK1ng FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compiler.updateis removed from the Intel ones. Now we use runners that have just v145 toolset by default and the v142 one is installed manually - that one is always v14.29, no need to encode the trailing9explicitly any more. Besides, end user (prebuilts consumer) won't have to pass-s "&:compiler.update=~"to erase thecompiler.updatesetting from our profile (thus not requiring exact match his locally installed toolset).msvc-userthat is meant to be used by end user in conjunction with our profiles like this:-pr <our profile> -pr dependencies/conan_profiles/base/msvc-user(order of profiles matters). This new partial profile sets user's MSVC compiler version automatically inferred from environment, just likeconan profile detectdoes when creating fresh build profile. Which means user won't have to pass-s "&:compiler.version=X"manually and figure out what to set in place of X.Build script fix to be able to pass it
lua_lib=Noneso that it doesn't build any Lua lib at all - required to make 32-bit ARM Android build succeed on F-Droid (as currently it's unable to build LuaJIT for 32-bit).Opus library is limited to version < 1.6 because 1.6 doesn't build for Windows ARM, but there is already PR to upstream: [fix] CMake linker failure on ARM when DNN is disabled and NEON uses RTCD xiph/opus#478
Small CI improvement by merging 2 steps into one.