Skip to content

Migrate Windows CI to Visual Studio 2026 and bump yaml-cpp to 0.9.0 #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elazarg merged 2 commits into from
Jun 22, 2026
Merged

Migrate Windows CI to Visual Studio 2026 and bump yaml-cpp to 0.9.0 #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b799ee
Fix Windows CI: migrate to Visual Studio 2026 runner image
elazarg Jun 22, 2026
79c48fc
Update fetched yaml-cpp to 0.9.0
elazarg Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ jobs:
configurations: [Debug, Release]
target: [tests, library]
fail-fast: false
runs-on: windows-2025
runs-on: windows-latest
env:
MATRIX_TARGET: ${{ matrix.target }}
BUILD_CONFIGURATION: ${{ matrix.configurations }}
CMAKE_GENERATOR: "Visual Studio 17 2022"
CMAKE_GENERATOR: "Visual Studio 18 2026"
steps:
- uses: actions/checkout@v6
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-2025]
os: [ubuntu-latest, macos-latest, windows-latest]

steps:
- uses: actions/checkout@v6
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
if: runner.os == 'Windows'
shell: pwsh
run: >
cmake -S . -B build -G "Visual Studio 17 2022"
cmake -S . -B build -G "Visual Studio 18 2026"
-D prevail_ENABLE_TESTS=OFF

# 3. Build
Expand Down
2 changes: 1 addition & 1 deletion cmake/SetupYAMLCPP.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (NOT TARGET yaml-cpp::yaml-cpp)

FetchContent_Declare(yaml-cpp
GIT_REPOSITORY https://github.com/jbeder/yaml-cpp.git
GIT_TAG 0.8.0
GIT_TAG yaml-cpp-0.9.0
Comment thread
coderabbitai[bot] marked this conversation as resolved.
GIT_SHALLOW TRUE
FIND_PACKAGE_ARGS NAMES yaml-cpp
)
Expand Down
Loading