Repository navigation
Add admin controls and configurable settings - #205
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…meout-config Add admin controls and configurable dispute settings
|
@ngoziobidigwe212 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #158
Closes #159
Closes #160
Closes #161
Summary
Adds the four requested contract fixes: admin-controlled reputation escrow rotation; zero-weight ratings no longer consume a rater/ratee aggregate slot; admin-managed dispute panel and threshold updates; and a configurable escrow dispute timeout (seven days by default). Panel changes invalidate existing approvals, and timeout changes apply only to future disputes. Contract references, deployment initialization, and timeout messaging are synchronized.
Related issue
No issue numbers were supplied.
Type of change
How was it tested?
source "$HOME/.cargo/env" && cd contracts && cargo fmt --all && cargo test— passed (24 dispute unit, 59 escrow unit, 21 reputation unit, and 3 integration tests).source "$HOME/.cargo/env" && cd contracts && cargo clippy --all-targets -- -D warnings— passed.cd backend && npm test -- src/__tests__/contractErrors.test.ts— passed (9 tests).cd backend && npx eslint src/lib/contractErrors.ts src/openapi.ts src/__tests__/contractErrors.test.ts— passed.cd frontend && npm run lint— passed.cd frontend && npx tsc --noEmit— passed.cd frontend && npm run build— passed.cd backend && npm run lint— failed on 39 existing lint errors in unrelated files.cd backend && npm run build— failed on existing type errors inbackend/src/routes/reputation.ts(lines 158 and 164), unrelated to these changes.Checklist
cd contracts && cargo fmt --all && cargo clippy --all-targets -- -D warnings && cargo testcd frontend && npm run lint && npx tsc --noEmit && npm run buildREADME.md/CONTRIBUTING.mdREADME.md/CONTRIBUTING.mdstill matchcontracts/*/src/lib.rs(signatures, preconditions, same function set in both)Wave complexity