RFC for zip_view implementation, for oneDPL C++20 - #1931
Conversation
dmitriy-sobolev
left a comment
There was a problem hiding this comment.
There is one question regarding the conversions of the iterators. The rest are minor stylistic and wording corrections.
Co-authored-by: Dmitriy Sobolev <Dmitriy.Sobolev@intel.com>
Co-authored-by: Dmitriy Sobolev <Dmitriy.Sobolev@intel.com>
Co-authored-by: Dmitriy Sobolev <Dmitriy.Sobolev@intel.com>
Co-authored-by: Dmitriy Sobolev <Dmitriy.Sobolev@intel.com>
There was a problem hiding this comment.
Pull request overview
This RFC proposes implementing zip_view for oneDPL's C++20 range APIs, providing functionality equivalent to C++23's std::ranges::zip_view but with device copyability support and compatibility for C++20 users.
Changes:
- Introduces RFC documentation for
oneapi::dpl::ranges::zip_viewimplementation - Defines key requirements including C++20 compatibility, API compliance with C++23 standard, and device copyability
- Proposes using
oneapi::dpl::__internal::tupleinstead ofstd::tupleto address technical limitations and ensure device copyability
Comments suppressed due to low confidence (3)
rfcs/proposed/zip_view/README.md:1
- Corrected spelling of 'Considiration' to 'Consideration'.
# zip_view Support for the oneDPL Range APIs with C++20
rfcs/proposed/zip_view/README.md:1
- Grammar error: 'another' should be 'other' when used with plural noun 'issues'.
# zip_view Support for the oneDPL Range APIs with C++20
rfcs/proposed/zip_view/README.md:1
- Grammar error: Use 'an' instead of 'a' before words starting with a vowel sound. Should be 'an indirectly writable requirement'.
# zip_view Support for the oneDPL Range APIs with C++20
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot can you fix the spelling error you identified as low confidence comment?
|
|
The key problem that still needs to be addressed is the choice of the namespace. We should not place the new API into |
|
danhoeflinger
left a comment
There was a problem hiding this comment.
LGTM with namespace changes
akukanov
left a comment
There was a problem hiding this comment.
Approved after making some cosmetic changes and adding a paragraph about the experimental stage.
When the RFC is moved to the experimental status, productization conditions (aka "exit criteria") will need to be described.
danhoeflinger
left a comment
There was a problem hiding this comment.
LGTM with the changes
The proposal to implement
zip_viewin oneDPL. A part of the general RFC discussion #1944 about implementing useful C++23 views.