Feature/win arm64 support by nithin-aashik-mcw · Pull Request #3718 · uxlfoundation/oneDAL

nithin-aashik-mcw · 2026-07-26T12:40:12Z

Add Windows ARM64 (winarm) build support

Adds native build support for oneDAL on Windows ARM64 using clang/lld-link, extending the existing win32e (MSVC) and lnxarm targets.

Build system

New winarm platform target with clang/lld-link/llvm-lib toolchain (winarm.mk, clang.ref.arm.mk, arm.mk, lnxarm.mk, vc.mkl.32e.mk, common.mk)
Registered winarm in top-level PLATs; made Windows flags (-Fo, -Q, -EHsc, link rules) conditional on MSVC vs. clang
Fixed TBB/OpenBLAS path resolution to be per-architecture ($(_IA)) instead of hardcoded to intel64, in both makefile and deps.ref.mk
Wired OpenBLAS into the same release-copy machinery as TBB
Added VS2026 build tools support with arch-aware vcvarsall.bat (replacing x64-only vcvars64.bat)

Core / algorithm compatibility (clang-cl ≠ real MSVC)

Guarded _MSC_VER-only code paths with !defined(__clang__) across daal_defines.h, service_defines.h, service_topo.cpp, env_detect_features.cpp, KD-tree KNN kernel, and oneapi/dal/{backend,detail}/common.hpp
Added ARM64 Windows SVE feature detection via KUSER_SHARED_DATA
Switched to _aligned_malloc/_aligned_free on Windows instead of POSIX aligned_alloc/free

CI / tooling

build.bat / test.bat: detect host arch (AMD64/ARM64), set PLAT=winarm, propagate ARCH_DIR through TBB/OpenBLAS paths
Fixed robocopy bug in tbb.bat deleting source dirs after move
Fixed OpenBLAS archive path casing (OpenBlas-* → OpenBLAS-*)
deploy/local/vars_win.bat: derive DAAL_IA from host arch instead of hardcoding intel64
examples/cmake/setup_examples.cmake / samples/cmake/setup_samples.cmake: recognize ARM64, fix intel_intel64 → intel64 naming

Testing

[✅] Built and ran examples/samples natively on Windows ARM64
[✅] CI passing on feature/win-arm64-support

…ndows

…ayout)

…test.bat and vars_win.bat

…-aashik-mcw/oneDAL into feature/win-arm64-support

napetrov · 2026-07-26T13:46:52Z

@nithin-aashik-mcw - thanks - might be we would go straight to bazel build system?

nithin-aashik-mcw · 2026-07-26T14:04:19Z

@napetrov Just to clarify, would you prefer that Windows ARM64 support be implemented in the Bazel build system instead?

icfaust

I'm hoping someone with more build knowledge with me especially on the llvm/windows side of things can tell our status on that currently on x86, while this adds good CI/testing conformance for llvm+arm+win, the macros are not coded for arm, but for llvm+win.

icfaust · 2026-07-27T15:23:20Z

+  TBB_VERSION: v2023.1.0
+  OPENBLAS_VERSION: v0.3.33


Need to be added to renovate.json for proper tracking.

icfaust · 2026-07-27T15:23:56Z

+  pull_request:
+    branches:
+      - main
+      - 'feature/**'


Help me understand the addition of feature/**

icfaust · 2026-07-27T15:25:38Z

+      - name: Setup MSYS2
+        shell: pwsh
+        run: |
+          Invoke-WebRequest https://github.com/msys2/msys2-installer/releases/download/2026-06-11/msys2-${{ matrix.os.arch }}-20260611.exe -UseBasicParsing -OutFile msys2-${{ matrix.os.arch }}.exe
+          .\msys2-${{ matrix.os.arch }}.exe install --confirm-command --root "C:\msys64"


Msys2 provides a github action for this, I think we can trust them on that and would be lower maintenance (unless not available for this os/cpu combo?) let me know

icfaust · 2026-07-27T15:26:55Z

+      - name: Install LLVM for Win-${{ matrix.os.arch }}
+        shell: pwsh
+        run: |
+          Invoke-WebRequest https://github.com/llvm/llvm-project/releases/download/llvmorg-22.1.8/LLVM-22.1.8-${{ matrix.os.llvm_arch }}.exe -UseBasicParsing -OutFile LLVM-${{ matrix.os.llvm_arch }}.exe


This way of installing llvm is likely to be high maintenance (hardcoded version in a url) is there any way to make this better for renovate tracking?

icfaust · 2026-07-27T15:27:18Z

+          Start-Process msiexec.exe -ArgumentList "/i cmake-${{ matrix.os.arch }}.msi /quiet /norestart" -Wait
+          echo "C:\Program Files\CMake\bin" >> $env:GITHUB_PATH
+
+          Invoke-WebRequest https://github.com/ninja-build/ninja/releases/download/v1.13.2/ninja-win${{ matrix.os.arch }}.zip -OutFile ninja-win${{ matrix.os.arch }}.zip


Help explain the use of ninja

icfaust · 2026-07-27T15:29:49Z

    #ifdef __GNUC__
        #define DAAL_DEPRECATED __attribute__((deprecated))
-    #elif defined(_MSC_VER)
+    #elif defined(_MSC_VER) && !defined(__clang__)


This should impact normal llvm builds on x86 using windows. Is this something we have checked what impact this may have?

icfaust · 2026-07-27T15:52:36Z

+#elif defined(TARGET_ARM) && defined(_MSC_VER)
+    #define KUSER_SHARED_DATA_ADDR   0x7FFE0000UL
+    #define PROCESSOR_FEATURES_OFFSET 0x274
+    #define PF_ARM_SVE_INSTRUCTIONS_AVAILABLE  46


This probably needs some code comments to make it more maintainable.

icfaust · 2026-07-27T15:55:05Z

+          $$(if $$(CHECK_DLL_SIG),Wintrust.lib))
+  $$(eval daaldep.winarm.rt.dpc  := $$(dep_dpc) \
+          $$(if $$(CHECK_DLL_SIG),Wintrust.lib))
+  $$(eval daaldep.win.threxport.create = grep -v -E '^(;|$$$$$$$$)' $$$$< $$$$(USECPUS.out.grep.filter))


This line is wild.

david-cortes-intel · 2026-07-29T07:30:10Z

@@ -0,0 +1,84 @@
+@echo off
+rem ============================================================================
+rem Copyright 2020 Intel Corporation


If this is not a copy-paste, please use the new copyright header:
https://github.com/uxlfoundation/oneDAL/blob/main/CONTRIBUTING.md#copyright-guidelines-for-contributions

david-cortes-intel · 2026-07-29T07:31:09Z

+
+setlocal
+
+rem req: PowerShell 3.0+


Aren't batch files meant to be runnable with the old Cmd.exe alone? Feels quite odd to launch powershell from a .bat file.

david-cortes-intel · 2026-07-29T07:31:28Z

+powershell.exe -command "if ($PSVersionTable.PSVersion.Major -lt 3) {Write-Host \"The script requires PowerShell 3.0 or above (current version: $($PSVersionTable.PSVersion.Major).$($PSVersionTable.PSVersion.Minor))\"; exit 1} else {exit 0}"
+if errorlevel 1 goto Error_load
+
+if /I not "%PROCESSOR_ARCHITECTURE%"=="ARM64" (


Does this mean that cross-compilation is not supported?

david-cortes-intel · 2026-07-29T07:33:37Z

+      - name: Checkout repository
+        uses: actions/checkout@v6
+
+      - name: Setup MSYS2


Would it not be a problem to mix msys2 with LLVM-based tools? And does msys2 provide something that the LLVM stack doesn't?

david-cortes-intel · 2026-07-29T07:35:07Z


 /* oneDAL 64-bit integer types */
-#if !(defined(__INTEL_COMPILER) || defined(__INTEL_LLVM_COMPILER)) && defined(_MSC_VER)
+#if !(defined(__INTEL_COMPILER) || defined(__INTEL_LLVM_COMPILER)) && defined(_MSC_VER) && !defined(__clang__)


I understand the CI is using clang-cl, not plain clang. Isn't that compiler supposed to provide the same headers with these kinds of definitions?

david-cortes-intel · 2026-07-29T07:35:58Z

+        os: [
+          { name: GitHub hosted, label: windows-11-vs2026-arm, cxx: clang, arch: arm64, isa: sve, llvm_arch: woa64 }
+        ]
+    name: Windows-${{ matrix.os.arch }}-${{ matrix.os.cxx }}-${{ matrix.os.isa }}-${{ matrix.os.name }}


Overall comment: would it be possible to build with conda-forge tooling as a separate job?
https://conda-forge.org/blog/2026/02/09/win-arm64/

david-cortes-intel · 2026-07-29T07:37:17Z

-    static void * serv_malloc(size_t size, size_t alignment) { return aligned_alloc(alignment, size); }
+    static void * serv_malloc(size_t size, size_t alignment) { 
+        #if defined(_MSC_VER)
+            return _aligned_malloc(size, alignment);


aligned_alloc is part of the C++17 standard:
https://en.cppreference.com/cpp/memory/c/aligned_alloc

Does MSVC or clang-cl not offer it?

david-cortes-intel · 2026-07-29T07:40:25Z

    #define PRAGMA_OMP_SIMD            PRAGMA_TO_STR(omp simd)
    #define PRAGMA_OMP_SIMD_ARGS(ARGS) PRAGMA_TO_STR_(omp simd ARGS)
-#elif defined(_MSC_VER)
+#elif defined(_MSC_VER) && !defined(__clang__)


This is in a series of elses that already checked for clang. It would have no effect.

david-cortes-intel · 2026-07-29T07:41:52Z

                     -DDAAL_REF -DONEDAL_REF -DDAAL_CPU=sve -Werror -Wno-empty-body -Wreturn-type \
                     $(COMPILER.lnx.clang.target) \
                     $(COMPILER.sysroot)
+COMPILER.win.clang= clang++ -march=armv8-a+sve \


As far as I know, there is no requirement to support SVE in order to run windows on ARM.

nithin-aashik-mcw added 30 commits July 23, 2026 02:50

Add arm64 support for oneTBB download and build in tbb.bat

5f4c63a

Introduce arm64 OpenBlas build script openblas.bat

d150119

Build: Add winarm platform target and clang toolchain definitions

e9a1e35

Build: Detect host arch in CI build.bat and set PLAT=winarm

9593a3f

Build: Fix TBB/OpenBLAS lib paths and naming for ARM64 on Windows

50ee538

Fix: Guard MSVC-only macros with !defined(__clang__) for clang builds

2061824

Fix: Use _aligned_malloc/_aligned_free instead of aligned_alloc on Wi…

38e060f

…ndows

Fix: Add ARM64 Windows SVE feature detection via KUSER_SHARED_DATA

1a54da1

Merge branch 'uxlfoundation:main' into feature/win-arm64-support

a70ebc9

Build: Add VS2026 build-tools support and fix OpenBLAS source dir casing

4bb400a

Fix: Stop robocopy from deleting TBB source bin/lib after move

92f97d7

Build: Resolve OpenBLAS release paths per-architecture (mirrors TBB l…

82cf8c5

…ayout)

Build: Add VS2026 support and per-arch TBB/OpenBLAS/DAAL_IA paths in …

845499b

…test.bat and vars_win.bat

Build: Recognize ARM64 CPU architecture in example/sample CMake setup

b886c5b

Chore: Drop debug echo from build.bat winarm branch

8512aed

Merge branch 'uxlfoundation:main' into feature/win-arm64-support

a638f96

CI: Introduce GitHub Actions pipeline for Windows ARM64

7810d64

Merge branch 'feature/win-arm64-support' of https://github.com/nithin…

52a3c84

…-aashik-mcw/oneDAL into feature/win-arm64-support

CI: Add feature branch and name change

6a5adfa

CI: Add OpenBlas and oneTBB Build

09dc5ed

CI: Add MSVC env setup

a9bec18

CI: Fix MSVC env script path

ba2ca21

CI: Add Build daal, Build onedal_c, Test daal, Test oneapi

60f57c3

CI: Add MinGW

04c25a8

CI: Add Setup MSYS2, Remove MinGW

6809c99

CI: Fix MSYS2, Made CI Generic to ARM64 & x86_64

c64f336

CI: LLVM version from 20.1.8 to 22.1.8

f30179c

CI: Fix Test daal & Test oneapi

feb6720

CI: Set Visual Studio 18 2026 as generator for Test daal & oneapi

f5d5bb8

Fix: Set test build type as Release

2b79b2d

nithin-aashik-mcw added 3 commits July 26, 2026 03:44

CI: Update cmake & ninja version

49dc9ac

CI: Add Visual Studio Version

6f2a43c

Merge branch 'uxlfoundation:main' into feature/win-arm64-support

55327ee

nithin-aashik-mcw requested review from Alexandr-Solovev, ahuber21, avolkov-intel, david-cortes-intel, ethanglaser, homksei, icfaust, napetrov and rakshithgb-fujitsu as code owners July 26, 2026 12:40

nithin-aashik-mcw mentioned this pull request Jul 26, 2026

Feature Request: Add official Windows ARM64 support #3706

Open

nithin-aashik-mcw added 3 commits July 27, 2026 01:00

CI: Fix Azure Pipeline CI fail.

1f49486

CI: Fix Azure Pipeline CI fail.

5e8b2e5

CI: Fix Azure Pipeline CI fail.

b05f989

icfaust reviewed Jul 27, 2026

View reviewed changes

david-cortes-intel reviewed Jul 29, 2026

View reviewed changes

nithin-aashik-mcw requested review from david-cortes-intel and icfaust July 29, 2026 14:51

Uh oh!

Conversation

nithin-aashik-mcw commented Jul 26, 2026

Add Windows ARM64 (winarm) build support

Build system

Core / algorithm compatibility (clang-cl ≠ real MSVC)

CI / tooling

Testing

Uh oh!

napetrov commented Jul 26, 2026

Uh oh!

nithin-aashik-mcw commented Jul 26, 2026

Uh oh!

icfaust left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants