[enhancement] expose original fast DAAL interface for self data distances in the oneDAL cosine_distances algo - #3712
Open
icfaust wants to merge 2 commits into
Open
Conversation
icfaust
requested review from
Alexandr-Solovev,
avolkov-intel,
david-cortes-intel and
ethanglaser
as code owners
July 24, 2026 12:42
Contributor
Author
|
/intelci: run |
1 similar comment
Contributor
Author
|
/intelci: run |
Contributor
Author
|
/intelci: run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Questions have been raised as to the new cosine distances implementation for speed and optimization. In order to speed changes in sklearnex (uxlfoundation/scikit-learn-intelex#2657) we need to open up the original optimized code path for cpu data. The optimization of two input distances can then be improved at a later input. The goal would be to add changes in sklearnex side to limit oneDAL offloading to single input data to match the daal4py implementation. These changes are needed in oneDAL to add the necessary interfaces.
It does it by removing y.has_data() errors and instead piping them to the proper pathways. Note that this means we are still using a somewhat unoptimized GPU path.
Checklist:
Completeness and readability
Testing
Performance