Skip to content

Allow on-screen button opacity below 10% - #1952

Open
Nightwalker743 wants to merge 1 commit into
utkarshdalal:masterfrom
Nightwalker743:feature/zero-control-opacity
Open

Nightwalker743 wants to merge 1 commit into
utkarshdalal:masterfrom
Nightwalker743:feature/zero-control-opacity

Conversation

@Nightwalker743

@Nightwalker743 Nightwalker743 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Description

Requested here: https://discord.com/channels/1378308569287622737/1537200734293065771

Allows setting the opacity of on-screen control buttons below 10% down to 0%.

Recording

Screen_Recording_20260917_235104_GameNative.mp4

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Allows setting on-screen control button opacity down to 0%, instead of the previous minimum of 10%. This change lets users make on-screen controls fully transparent, as requested.

Written for commit 06c7251. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • New Features
    • Button opacity settings now support fully transparent buttons with values from 0.0 to 1.0.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5fa69a7e-cc37-4878-b7b5-4cf58dd25cd3

📥 Commits

Reviewing files that changed from the base of the PR and between 88a60ef and 06c7251.

📒 Files selected for processing (1)
  • app/src/main/java/app/gamenative/ui/component/dialog/ElementEditorDialog.kt

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The button opacity slider now supports values from 0.0 to 1.0, including fully transparent buttons.

Changes

Button opacity

Layer / File(s) Summary
Allow zero opacity
app/src/main/java/app/gamenative/ui/component/dialog/ElementEditorDialog.kt
The button opacity slider range now starts at 0.0f instead of 0.1f.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 06c72

The requested fully transparent button setting is supported without an identified regression, so the change is mergeable.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: allowing on-screen button opacity below 10%.
Description check ✅ Passed The description includes the required sections, explains the change, provides a recording link, identifies the change type, and completes most checklist items. The recording checklist item remains unc…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant