Trigger a type check for an entire Rascal project from VS Code#1153
Open
rodinaarssen wants to merge 34 commits into
Open
Trigger a type check for an entire Rascal project from VS Code#1153rodinaarssen wants to merge 34 commits into
rodinaarssen wants to merge 34 commits into
Conversation
DavyLandman
reviewed
Jul 10, 2026
DavyLandman
left a comment
DavyLandman
left a comment
Member
There was a problem hiding this comment.
Very nice! I have some small remarks. But the most important one is that I'm missing a UI test for this feature.
| <dependencyMsgs, checkedForImports, dependencies> = buildDependencyGraph(checkForImports, openFileHeader.src, workspaceFolders, getParseTree, getPathConfig); | ||
|
|
||
| if ([] != dependencyMsgs) { | ||
| // Since we only reported errors on `l`, there is not need to analyze to which files the errors belong here. |
Member
There was a problem hiding this comment.
how is this true? can't we have error from our dependencies?
Member
Author
There was a problem hiding this comment.
This is the "check-on-save" path, where errors have never been reported on dependencies, but on the file itself
toinehartman
left a comment
toinehartman
left a comment
Member
There was a problem hiding this comment.
Nice feature! Looks good. I don't love the additional document service endpoint, since it's only for Rascal (and does not mean anything for parametric or the to-be-added routing server).
rodinaarssen
force-pushed
the
check-full-project
branch
from
July 16, 2026 11:57
84cde51 to
943a6d7
Compare
rodinaarssen
force-pushed
the
check-full-project
branch
from
July 16, 2026 11:58
943a6d7 to
fb5e1d0
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
This PR may depend on a release of Rascal that contains usethesource/rascal#2815