Repository navigation
Conversation
…ow_run Compresses the pins check from 30 lines to 20 while keeping every case it catches, including the safety net that fails when a pin cannot be read at all rather than comparing two empty strings. Also records why `gh pr merge --auto` is not used: auto-merge only holds a pull request for checks that branch protection marks as required, and main has none, so GitHub refuses to arm it and would merge regardless of the build. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #21, which was merged before this landed on the branch.
pinsdrift check from 30 lines to 20. Every case it catches is unchanged, re-verified against a deliberately broken tree: the two golangci-lint versions disagreeing, the twoFROM golang:lines disagreeing,go.modasking for a newer Go than the base image, and a base image newer than thegodirective still passing (legal, and stops a Dependabot base-image bump from blocking its own PR). The safety net that fails when a pin cannot be read at all — rather than comparing two empty strings and passing — is also covered by tests.automerge.ymlandsync-pins.yml.Why
gh pr merge --autostill isn't usedRecorded in the workflow now, because it is not obvious and cost some digging:
mainhas none, so GitHub refuses to arm it (Pull request is in clean status) and the documented workaround — falling back to a plaingh pr merge— merges immediately, build or no build.pull_request_target+gh pr checks --watch, deadlocks:pull_request_targetruns appear ingh pr checks, so it waits on itself.So the
workflow_runtrigger and its guards are load-bearing, not ceremony. If you'd rather have the six-line version, someone with admin needs to turn on Allow auto-merge and addmain+pinsas required checks onmain— I don't have admin here (PATCH /repos/upsun/vinegoreturns 404). Say the word and I'll swap it.🤖 Generated with Claude Code