Skip to content

fix(macos): build x86_64 with the standalone spc binary - #2

Merged
pjcdawkins merged 2 commits into
mainfrom
fix/macos-intel-standalone-spc
Sep 25, 2026
Merged

pjcdawkins merged 2 commits into
mainfrom
fix/macos-intel-standalone-spc

fix(macos): verify the spc download before extracting it

a67f105
Select commit
Loading
Failed to load commit list.
Upsun Dispatch / Upsun Dispatch™ Code Review succeeded Sep 25, 2026 in 35s

No issues found

incremental · 1 file reviewed · no issues found

Verification
  • The pinned SPC_MACOS_X86_64_SHA256 equals the GitHub-published digest of spc-macos-x86_64.tar.gz in the static-php-cli 2.8.5 release.
  • The tarball is now written to disk and checked with shasum -a 256 -c before tar extracts it, so a mismatch fails the step before anything runs.
  • Extracting straight into spc/bin gives spc/bin/spc, the same path the old mv spc/spc spc/bin/spc produced, matching the later ./bin/spc calls.

No automated test covers the workflow change. The only evidence is the manual dispatch run linked in the PR description, plus the spc/bin/spc --version smoke check inside the download step.

Review details