Update invite links from http to https. - #73
Merged
Merged
Conversation
Member
Author
ldko
requested changes
May 28, 2026
ldko
left a comment
ldko
left a comment
Member
There was a problem hiding this comment.
Rather than hardcoding https (so it works in a dev environment etc.), does it work to use request.scheme? I think it should work even behind a load balancer because of us setting SECURE_PROXY_SSL_HEADER.
Member
Author
|
Yeah it looks like that works just fine (tested in dev via hostname and through the alpha domain), I'll make the changes. |
ldko
approved these changes
May 29, 2026
ldko
left a comment
ldko
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Just a minor suggestion for the changelog for consistency.
Contributor
|
Looks good to me! |
clarktr1
approved these changes
Jun 4, 2026
Co-authored-by: Lauren Ko <lauren.ko@unt.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.