Repository navigation
feat(genesis): unify device-resident DR lifecycle - #477
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Unify whole-MJCF and portable Genesis scenes on one device-resident runtime DR lifecycle and remove the legacy portable host reset/interval path.
Motivating UniLab roadmap: Motphys/UniLab#2520.
Contract
DomainRandomizationCapabilitiesis split authoritatively by plane.body_mass,kp,kdbody_force,body_torqueValidation
uv run pytest -q— 1864 passed, 120 skippedruff check .— passedruff format --check— passedmypy src/unisim— passedpyright— passedcheck_support.py --check-docs— passedCUDA_VISIBLE_DEVICES="")Follow-up
After this is released, UniLab PR Motphys/UniLab#2523 will bump the default and ROCm
unisim-corepins and regenerate both lockfiles. That PR intentionally remains non-mergeable until the release exists.