Skip to content

chore: initial commit with the configurations files - #2

Open
Eduardo-Morais wants to merge 23 commits into
mainfrom
migration-tool
Open

Eduardo-Morais wants to merge 23 commits into
mainfrom
migration-tool

Conversation

@Eduardo-Morais

Copy link
Copy Markdown
Collaborator

No description provided.

@winiciusallan winiciusallan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Eduardo-Morais for your hard work!

There are a lot of requested changes, especially typos. Considering a multinode deploy, you'll have to change the logic from your tasks to run in specific nodes. For example:

  • Run the task to change the ml2_conf.ini needs to be done in the deploy node

and so on...

Also, you need to have strong documentation that supports your decision and how the entire process occurs. This involves deleting tables from the database, which may be a very critical operation.

I missed a group_vars file so we can define variables to use in the playbook. Some environments use virtual environments to install kolla-ansible, so you should source them before running any playbook. You can add this as an additional step or as a requirement, but you should detail it in the docs.

Comment thread README.MD Outdated
Comment thread init_migration.yml Outdated
@@ -0,0 +1,7 @@
---
- name: migration OVS plugin to OVN
hosts: localhost

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok in all-in-one environments, but you should keep in mind that we will run this on a multinode cluster.

Here you can see that kolla defines a host group for network nodes, so you may need to change this to keep the consistency.

Do you need to perform any specific task on compute nodes? If so, you need to add logic to run in those nodes.

Comment thread migration/vars/main.yml Outdated
Comment on lines +2 to +4
mariadb_user:
mariadb_password:
path_to_hosts:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't have any defaults, this file is useless. Let's delete it and let the user define them.

Comment thread migration/tasks/main.yml Outdated
Comment thread migration/tasks/main.yml Outdated
Comment thread migration/tasks/ovn_deploy.yml Outdated
Comment thread migration/tasks/ovn_deploy.yml Outdated
Comment thread migration/tasks/ovn_deploy.yml Outdated
Comment thread migration/tasks/finishing_the_migration.yml Outdated
Comment thread migration/tasks/finishing_the_migration.yml Outdated
Eduardo-Morais and others added 13 commits January 22, 2026 14:21
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>

@winiciusallan winiciusallan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments inline. Let me know what you think.

Comment thread README.md
Comment thread migration/tasks/ovn_deploy.yml Outdated
Comment thread migration/tasks/ovn_deploy.yml Outdated
Comment thread migration/tasks/post_migration.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants