chore: initial commit with the configurations files - #2
Eduardo-Morais wants to merge 23 commits into
Conversation
There was a problem hiding this comment.
Thanks @Eduardo-Morais for your hard work!
There are a lot of requested changes, especially typos. Considering a multinode deploy, you'll have to change the logic from your tasks to run in specific nodes. For example:
- Run the task to change the ml2_conf.ini needs to be done in the deploy node
and so on...
Also, you need to have strong documentation that supports your decision and how the entire process occurs. This involves deleting tables from the database, which may be a very critical operation.
I missed a group_vars file so we can define variables to use in the playbook. Some environments use virtual environments to install kolla-ansible, so you should source them before running any playbook. You can add this as an additional step or as a requirement, but you should detail it in the docs.
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| - name: migration OVS plugin to OVN | |||
| hosts: localhost | |||
There was a problem hiding this comment.
This is ok in all-in-one environments, but you should keep in mind that we will run this on a multinode cluster.
Here you can see that kolla defines a host group for network nodes, so you may need to change this to keep the consistency.
Do you need to perform any specific task on compute nodes? If so, you need to add logic to run in those nodes.
| mariadb_user: | ||
| mariadb_password: | ||
| path_to_hosts: |
There was a problem hiding this comment.
If you don't have any defaults, this file is useless. Let's delete it and let the user define them.
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
Co-authored-by: Winicius Allan <winiciusab12@gmail.com>
winiciusallan
left a comment
There was a problem hiding this comment.
A few comments inline. Let me know what you think.
No description provided.