First Changes to the Sponsorship Page - #28
Conversation
|
There was a problem hiding this comment.
Write DRY code. This code is very repetitive and not scalable. I would suggest creating a helper function in a separate folder modules/ to read from a JSON file and generate the react component for all the sponsors. Such that in the future, if we want to create a page for 2026 sponsors, all we have to do is modify the JSON file. The JSON file would most likely be in it's own folder under Pages/ like configs/.
There was a problem hiding this comment.
I just pushed a new set of commits to lay the groundwork for these changes. I incorporated .json files to store the source data for sponsors, electrical team members, and electrical team projects. The .jsx files now just read from these .json files using a simple mapping loop, resulting in cleaner files and more scalable code
- Implemented a Sponsor.json configuration file that has all of the listed sponsors from 2012-2023. New sponsors can be easily added and old sponsors can be removed by following the structure of data - Refactored Sponsors.jsx to read data directly from the Sponsors.json file, resulting in a much cleaner and more scalable file - Also refactored the additions to the new electrical page to use Electrical.json and Electrical-Projects.json config files. This allows for scalability and easy of addition and removal of new members and projects - Contains the horizontal layout of the team descriptions on the home page
2 participants
Added a new folder within assets for all of the sponsorship assets.
Sponsors for years 2023-2012 are now updated.
Initial styling for the page is done, but needs more work in the future.
Donate Button added at the end of the page.
Basic animation added to image hovers