Repository navigation
fix(router): honor Cache-Control no-transform and strip modern digest headers when rewriting HTML (fixes #37) - #52
Closed
bigchungusai wants to merge 1 commit into
Conversation
… headers when rewriting HTML (fixes ubiquity#37)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37
/wallet 0xf36e02A6d81EdDAE7bcEAF6d7c1005099D54F488
Summary
src/utils/revision-footer.tsand wireddecorateHtmlRevisionFooterintosrc/worker.tsso HTML responses are decorated with the router revision footer only when neither the request nor the responseCache-Controlheader containsno-transform.Content-Digest,Repr-Digest) alongside legacy representation validators (Content-Length,Content-MD5,Digest,ETag) whenever an HTML payload is rewritten.tests/revision-footer.test.tscoveringno-transformin the request,no-transformin the response, andContent-Digest/Repr-Digeststripping on rewritten HTML.Verification
bun test(23 passed across 3 files)bun run type-check(tsc --noEmit)Bounty Payout Wallet (Base / Ethereum / Gnosis / EVM):
0xf36e02A6d81EdDAE7bcEAF6d7c1005099D54F488Bounty Payout Wallet (Solana SOL / USDC-SPL):
HmrmUuXJiQpgYET15VZYcx5wceSRamjVTsewKqWNL3JC