Repository navigation
fix(auth): return 401 for rejected Passport exchange codes (#1281) - #1367
Closed
hardik4love-lang wants to merge 1 commit into
Closed
hardik4love-lang wants to merge 1 commit into
hardik4love-lang wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1281
Problem
When Passport returns a normal 4xx response for an expired or invalid authorization code, \�oundedJson\ previously converted every non-2xx response into \PassportError(502), causing the callback to report service unavailability instead of an authentication failure.
Solution
esponse.status >= 400 && response.status < 500\ immediately after the SSO exchange request and throw \PassportError(401).