Repository navigation
Demo #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Demo #26
Changes from all commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
5486b56
chore: update workflow to include `demo` branch in deployment checks
gentlementlegen df1b7f6
chore: [skip ci] updated manifest.json and dist build
github-actions[bot] 9ce6c01
Merge pull request #14 from gentlementlegen/demo
gentlementlegen 8f3c72c
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] a81dbc7
chore: update dependencies to latest versions, including @ubiquity-os…
gentlementlegen d39d953
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 7cd9ddd
chore: update packages
gentlementlegen 369eb86
chore: update packages
gentlementlegen d2d15a9
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 59639fa
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] a41c75e
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] a1e9e58
chore: update knip config and remove unused type guard
gentlementlegen 028afaf
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 2755e46
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 239e046
test: increase timeout for main.test.ts
gentlementlegen 3bee74a
Merge branch 'demo' into fix/demo
gentlementlegen 448ab48
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] e9c4aee
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 206175a
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] c0bb39c
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 38c0ad4
Merge pull request #16 from ubiquity-os/fix/demo
gentlementlegen 386a6ce
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 4e7df69
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 00917ea
chore: update dotenv and ts-node dependencies to latest versions
gentlementlegen 9a88347
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 5895b6d
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 12e7746
fix: handle invalid GitHub credentials and fix infinite loop
gentlementlegen d559e45
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 2d7c0a9
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] b121378
chore: remove extra space in BAD_CREDENTIALS_MESSAGE string
gentlementlegen 3a46bb9
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 3bd8c70
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] e20dba4
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 46cf247
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 3ee8159
Merge remote-tracking branch 'origin/demo' into fix/demo
gentlementlegen a26ae17
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] bde9c79
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 63252dd
chore: migrate to @swc/jest, update Jest setup, and clean up unused d…
gentlementlegen 8942054
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 8a238cc
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] d37582f
chore: remove unused cross-env dependency from bun.lock and package.json
gentlementlegen c910e92
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] a01710c
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 5c7a016
Merge pull request #17 from ubiquity-os/fix/demo
gentlementlegen 23732e3
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 87f09f5
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] da72f32
fix: pin manifest workflow to issue-27 deploy action
gentlementlegen bde0ed2
fix: sync workflow skipBotEvents and parameter metadata
gentlementlegen c5cf744
fix: exclude issue_comment.created from manifest listeners
gentlementlegen c1c5b85
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] fa3a05d
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 26b4c81
Update update-configuration.yml
gentlementlegen 66be4a1
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 51d1a47
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] e79ee58
chore: [skip ci] update labels configuration
ubiquity-os-beta[bot] e056bb5
chore: [skip ci] update labels configuration
ubiquity-os-beta[bot] 2f5158b
chore: [skip ci] update labels configuration
ubiquity-os-beta[bot] b2444ae
chore: [skip ci] update labels configuration
ubiquity-os-beta[bot] 372c7fd
chore: [skip ci] update labels configuration
ubiquity-os-beta[bot] 4857d93
Merge remote-tracking branch 'origin/development' into codex/fix/mani…
gentlementlegen 62670c5
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 8681352
Merge remote-tracking branch 'origin/demo' into codex/fix/manifest-bu…
gentlementlegen 076c9e1
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 72d3f3b
Merge remote-tracking branch 'origin/codex/fix/manifest-build-plugin-…
gentlementlegen 9b7f161
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 50a4bfa
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 2de815b
Update update-configuration.yml
gentlementlegen 3820add
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 0b4e0be
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 828a601
chore: [skip ci] Update manifest.json
gentlementlegen 9c6f2c4
Merge pull request #19 from ubiquity-os/codex/fix/manifest-build-plug…
gentlementlegen 0016a7c
chore: [skip ci] updated manifest.json and dist build
ubiquity-os-beta[bot] 824f571
chore: [skip ci] update manifest.json url
ubiquity-os-beta[bot] 88bc621
chore(ci): migrate demo branch to artifact deploy flow
gentlementlegen dcf9658
fix(ci): generate manifest before deno deploy
gentlementlegen d1bfdae
fix(ci): install dependencies before deno deploy manifest step
gentlementlegen 1af8791
Merge pull request #20 from ubiquity-os/feat/320-workflow-artifact-mi…
gentlementlegen 2b1650a
chore(ci): sync demo with development deploy flow
gentlementlegen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: ubiquity-os/command-demo
Length of output: 50
🌐 Web query:
Does@ubiquity-os/ubiquity-os-loggererror method return an Error object?💡 Result:
No, the
@ubiquity-os/ubiquity-os-loggererror method does not return an Error object. Evidence from Ubiquity OS plugin SDK documentation and usage shows the logger provides methods like logger.ok("Done"), which are used for logging messages, not throwing or returning Error instances. In error contexts from GitHub issues (e.g., command-start-stop#136), errors are standard JavaScript Error objects ("name": "Error") passed to logging, indicating the logger.error likely logs the error rather than returning one. No sources explicitly state or demonstrate the error method returning an Error object; it aligns with standard logger patterns where log methods return void or log metadata.Citations:
🏁 Script executed:
Repository: ubiquity-os/command-demo
Length of output: 715
🏁 Script executed:
Repository: ubiquity-os/command-demo
Length of output: 301
🏁 Script executed:
Repository: ubiquity-os/command-demo
Length of output: 220
Fix throwing logger.error() calls — logger.error() returns void, not Error.
The code at lines 33-35 throws
context.logger.error(), but this method returnsvoid(confirmed via package documentation). Throwingundefinedbreaks exception handling and loses stack traces. This pattern also appears insrc/handlers/run-demo.ts.Instead, log first then throw a proper Error:
Example fix