Scala 3#1105
Open
i10416 wants to merge 37 commits into
Open
Conversation
address compiler warnings/errors and setup kind-projector migration
|
|
Contributor
|
Thanks for doing this! I'll look at it in the next days. It's quite large obviously so it will take some time. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1105 +/- ##
===========================================
- Coverage 89.60% 89.58% -0.03%
===========================================
Files 119 124 +5
Lines 10016 10050 +34
Branches 695 572 -123
===========================================
+ Hits 8975 9003 +28
- Misses 1041 1047 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
This is great! I can help out with the review. |
Some source files are moved or copy-pasted to reduce compile errors in Scala 3. They will be removed after tweaking build in future commits.
i10416
commented
Apr 3, 2023
| private[algebird] trait CompatDecayedVector { | ||
| // This is the default monoid that never thresholds. | ||
| // If you want to set a specific accuracy you need to implicitly override this | ||
| implicit def monoid[F, C[_]](implicit vs: VectorSpace[F, C], metric: Metric[C[F]]):Monoid[DecayedVector[C]] = |
Author
There was a problem hiding this comment.
This won't compile in Scala 3 as Scala 3 requires explicit type annotation for implicit def.
Error says
Cannot find VectorSpace type class for Container: C
where: C is a type in method monoid with bounds <: [_] =>> Any
and Ring: Double
Author
|
Now, algebirdCore 3.2.2 compiles in d123047 |
copy changes from twitter#1108 to make it easier to resolve conflict
Author
|
Now, algebird-core and algebird-test compile in Scala 2.11, 2.12, 2.13 and 3 at 7042270 and all tests but CollectionSpecification pass. CollectionSpecification gets StackOverflow probably because of difference of implicit resolution between Scala 2.x and Scala 3. I'm going to reduce copy-paste files in algebird-core using traits as in https://github.com/twitter/algebird/pull/1105/files#diff-1ae6af35211d6d6fea648cfe842339cd2d4d08933aed665a3ec78e5aee3c12f1. |
i10416
commented
Apr 9, 2023
| } | ||
|
|
||
| implicit def mapArb[K: Arbitrary, V: Arbitrary: Monoid] = Arbitrary { // scalafix:ok | ||
| implicit def mapArb[K: Arbitrary, V: Arbitrary: Monoid]:Arbitrary[Map[K, V]] = Arbitrary { // scalafix:ok |
Author
There was a problem hiding this comment.
Strangely, explicit type annotation Arbitrary[Map[K, V]] here makes tests stack overflow.
Author
Author
|
@regadas Hi, could you run CI and look through changes? For now, algebird-core and algebird-test compile in Scala 3 andall tests in algebird-core and all tests but CollectionSpecification in algebird-test pass on my local machine. |
Author
|
Sorry for forgetting fmt and check before asking for the review. |
scalameta says "pattern must be a value" for macro entrypoint, but it compiles and is proper format.
Author
|
This is a false-positive error message at macro entrypoint. Possibly bugs in scalameta?
|
Author
|
I found the same issue in scalameta. scalameta/scalameta#3063 |
Workaround: skip compiling java api for Scala 3 because
1. it seems Scala 3 generates Monoid$ in later stage than Scala 2.x,
which prevents javaapi from compiling due to missing symbol.
2. we cannot use `compileOrder := CompileOrder.ScalaThenJava`
as algebird-core must compile CassandraMurmurHash.java BEFORE Scala,
but at the same time algebird-core must compile javaapi AFTER Scala.
Author
|
@regadas Sorry for the previous request, it is now ready for review (this time, for sure) |
Author
|
minimized reproduction of d51aa1b https://github.com/i10416/reproduce-missing-symbol-error-in-scala-3 |
Author
|
@regadas Could you review changes when you have a time? |
|
do it support scala3 ? why not to publish release version for scala3 |
Author
|
I'm not 100% sure as It has been a while since I made this PR, but IIRC this compiles and passes tests in Scala 3. I'm happy to resume on this to resolve conflict and tweak build. |
now
HI, if convienient use your ahead branch with scala3 to test something ? do you know https://github.com/spotify/featran ？ this featran dependent on algebird, now if use version 0.8 featran-core just run this scala program if you could get the console result like this ，you could publish your branch to maven center repo help many people |
I have try to copy your SCALA3 algebird branch : algebird-core /src/main/scala dir , but could not work and compile on scala3 , some error like this ,so I think maybe you need fixup these bug if you convinient ,thanks , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1099
NOTE:
changes for compatibility between 2.11, 2.12, 2.13 and 3.x
Source files compatible across all Scala version above are located in algebird-core/src/main/scala directory.
The most of changes in scala dir are to add explicit apply (
()) and to resolve ambiguous values.Some files in scala-2.11 and scala-2.12+ are almost the same but there are a few differences.
*s from kind-projector are replaced by_in 2.12+._are replaced by?in 2.12+.asInstanceOf[T])(1) and (2) are necessary mainly because Scala 2.11 does not support "-Xsource:3" and "-P:kind-projector:underscore-placeholders" which are necessary for smooth kind-projector migration.
These duplicated files can be deleted after dropping Scala 2.11. For more details, see https://docs.scala-lang.org/scala3/guides/migration/plugin-kind-projector.html
Scala 3 macros
Macros in algebird-core are ported to Scala 3, but there are still room for peformance and type safety improvement.
Scala 3 macros in algebird-core are extracted to https://github.com/i10416/algebird-macros for debug and test purpose.