Update some comments to note why we need StaticRawIter/SendPtr wrappers - #22
Merged
Conversation
…r types Unfortunately as we are holding NonNulls across await points, we'll still need some kind of adapter to mark this as sound. This means that hawkw/mycelium#536 is not in and of itself sufficient. Comments have been updated to reflect this.
Contributor
Author
|
This is a bit of a trivial PR, but I wanted to see if 536 would fix this, and unfortunately it won't because we ALSO hold the NonNull pointers across an await point. I did a minor change to impl Iterator on the wrapper type so we could use a normal for-loop, but this is mostly a documentation change. |
JuliDi
approved these changes
Jun 4, 2025
JuliDi
left a comment
JuliDi
left a comment
Contributor
There was a problem hiding this comment.
Looks very good, thank you!
Only a small typo, send vs Send
Co-authored-by: Julian <20155974+JuliDi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately as we are holding NonNulls across await points, we'll still need some kind of adapter to mark this as sound. This means that hawkw/mycelium#536 is not in and of itself sufficient.
Comments have been updated to reflect this.