Repository navigation
Conversation
Register fresh Symbol handles using the existing private atomic-counter allocator, skipping occupied predicate, primitive-row and import-state names. Declare its builtin signature and deterministic cardinality without adding a per-handle registry or metatype lookup. Do not snapshot a load that allocates fresh spaces: the counter is outside the cached runtime state. Loads defining factories without allocating remain cacheable. Cover ordinary, computed, strict-det and cached-load routes, Symbol/Grounded behavior, handle lifetime and occupancy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On main, (= (make-space) (new-space)) returns the unevaluated new-space
expression. Using that result with add-atom then raises an atom type error.
Register new-space as a runtime operation with a Symbol result and
deterministic cardinality, so ordinary, computed and strict-det factory
calls allocate fresh spaces.
Use the private atomic-counter allocator from stable PR #321, including
occupied-name checks and handles that cannot collide with a literal space
symbol. It keeps the existing Symbol representation without retaining every
unused handle in a registry.
A main-specific cache safeguard leaves loads that allocate spaces uncached:
replaying a captured handle without advancing the allocator could reuse that
handle. Files that only define a factory remain cacheable. The safeguard adds
two counter reads on a cache miss and no work to the cache-hit path.
Validation against upstream main ee5cacb:
its optional tilepuzzle oracle comparison reaches its existing timeout.
under each of --strict and --strict-det, and two expected Symbol/Grounded
mismatches pass on SWI-Prolog 10.1.9 and 10.1.20.
test_second_load_replays_the_snapshot failure also occurs on unchanged main.
unrelated scalar/data-head/computed-call inference counts match main.