Skip to content

fix: GPU tensor allocation fall back to host memory #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattwittwer merged 2 commits into from
Oct 7, 2026
Merged

fix: GPU tensor allocation fall back to host memory #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8568050
fix: Handle CPU_PINNED output buffers when GPU tensors fall back to h…
mattwittwer Oct 1, 2026
264a7a0
Update copyright
mattwittwer Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions src/pb_memory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2022-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// Copyright 2022-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -52,7 +52,8 @@ PbMemory::Create(
shm_pool->GetCUDAMemoryPoolManager(), memory_type, memory_type_id,
byte_size, data, memory_shm.data_.get(), memory_shm.handle_, copy_gpu);

if (memory_type == TRITONSERVER_MEMORY_CPU) {
if (memory_type != TRITONSERVER_MEMORY_GPU) {
// CPU and CPU_PINNED intermediates both live in shared memory.
data = memory_shm.data_.get() + sizeof(MemoryShm);
}

Expand Down Expand Up @@ -123,25 +124,22 @@ PbMemory::CopyBuffer(
" != " + std::to_string(src->ByteSize()));
}

if (src->MemoryType() == TRITONSERVER_MEMORY_CPU &&
dst->MemoryType() == TRITONSERVER_MEMORY_CPU) {
// CPU and CPU_PINNED are both host memory for the purpose of copies.
const bool src_is_host = (src->MemoryType() != TRITONSERVER_MEMORY_GPU);
const bool dst_is_host = (dst->MemoryType() != TRITONSERVER_MEMORY_GPU);

if (src_is_host && dst_is_host) {
std::memcpy(dst->DataPtr(), src->DataPtr(), dst->ByteSize());
return;
}

#ifdef TRITON_ENABLE_GPU
cudaMemcpyKind kind = cudaMemcpyHostToDevice;

if (src->MemoryType() == TRITONSERVER_MEMORY_CPU &&
dst->MemoryType() == TRITONSERVER_MEMORY_GPU) {
cudaMemcpyKind kind;
if (src_is_host && !dst_is_host) {
kind = cudaMemcpyHostToDevice;
} else if (
src->MemoryType() == TRITONSERVER_MEMORY_GPU &&
dst->MemoryType() == TRITONSERVER_MEMORY_CPU) {
} else if (!src_is_host && dst_is_host) {
kind = cudaMemcpyDeviceToHost;
} else if (
src->MemoryType() == TRITONSERVER_MEMORY_GPU &&
dst->MemoryType() == TRITONSERVER_MEMORY_GPU) {
} else {
kind = cudaMemcpyDeviceToDevice;
}

Expand Down
12 changes: 10 additions & 2 deletions src/python_be.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1529,7 +1529,11 @@ ModelInstanceState::ResponseSendDecoupled(
bool cuda_used;

try {
if (pb_memory->MemoryType() == TRITONSERVER_MEMORY_CPU) {
if (pb_memory->MemoryType() == TRITONSERVER_MEMORY_CPU ||
pb_memory->MemoryType() == TRITONSERVER_MEMORY_CPU_PINNED) {
// The GPU tensor was staged into a shared-memory intermediate by
// the stub (Triton fell back to host / pinned output memory), so
// it still has to be copied into the Triton-provided buffer.
THROW_IF_TRITON_ERROR(CopyBuffer(
"Failed to copy the CPU output tensor to buffer.",
TRITONSERVER_MEMORY_CPU, 0, TRITONSERVER_MEMORY_CPU, 0,
Expand Down Expand Up @@ -1838,7 +1842,11 @@ ModelInstanceState::ProcessRequests(
void* pointer = buffer_memory_pair.second;
bool cuda_used = false;

if (pb_memory->MemoryType() == TRITONSERVER_MEMORY_CPU) {
if (pb_memory->MemoryType() == TRITONSERVER_MEMORY_CPU ||
pb_memory->MemoryType() == TRITONSERVER_MEMORY_CPU_PINNED) {
Comment thread
mattwittwer marked this conversation as resolved.
// The GPU tensor was staged into a shared-memory intermediate by
// the stub (Triton fell back to host / pinned output memory), so
// it still has to be copied into the Triton-provided buffer.
GUARDED_RESPOND_IF_ERROR(
responses, response_index,
CopyBuffer(
Expand Down
Loading