Repository navigation
Conversation
Adopt the shared pre-commit baseline: two-line SPDX header, conventional commit message validation (commit-msg stage), and the centralized add-license / add-spdx-license hooks from developer_tools v0.2.0. Run pre-commit CI only on files modified by the PR, and roll out the standard issue templates and the simplified single PR template. TRI-1100
Legal's Copyright / License Header Guidance specifies the SPDX form without a comma after the year. TRI-1100
Human-readable type labels with enforced descriptions and colors. TRI-1100
Deliberate maintenance bump to include the year of the current modifications; required by the add-license hook's new staleness check (hooks themselves never modify LICENSE files). TRI-1100
Workflow files are license-processed again (only templates excluded); refresh the stale copyright year this repo's pre-commit workflow carried. TRI-1100
Grant issues:write to the labeling job (review feedback). TRI-1100
Greptile SummaryThis PR aligns the repository's CI configuration with the org-wide setup in
Confidence Score: 5/5Safe to merge — all changes are CI/tooling configuration with no application logic affected. The changes are confined to CI workflow files, pre-commit configuration, and a copyright year update. The null-delimited git diff approach correctly handles filenames with spaces. The pull_request_target guard correctly restricts that event to fork PRs only, passes minimal write permissions, and delegates to a pinned reusable workflow that does not check out PR code. No application code is touched. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant GH as GitHub PR Event
participant CPR as conventional-pr.yml caller
participant OrgWF as org .github conventional-pr.yml at v1.4.3
participant PC as pre-commit.yml
participant PCHooks as Pre-commit Hooks
Dev->>GH: Opens or updates PR
GH->>CPR: pull_request same-repo OR pull_request_target fork
CPR->>CPR: if condition routes by fork vs same-repo
CPR->>OrgWF: uses conventional-pr.yml at v1.4.3 with write permissions
OrgWF-->>GH: Validate PR title, derive label, detect cherry-picks
GH->>PC: pull_request event
PC->>PC: checkout fetch-depth 2 and restore cache
PC->>PC: "git diff -z --diff-filter=d HEAD^1 HEAD"
PC->>PCHooks: xargs -0 pre-commit run --files
PCHooks-->>PC: isort, black, flake8, clang-format, codespell, add-license
PC-->>GH: Pass or Fail
Dev->>Dev: git commit locally
Dev->>PCHooks: commit-msg hook fires via conventional-pre-commit
PCHooks-->>Dev: Validates type colon title format
Reviews (2): Last reviewed commit: "ci: harden CI workflows and configs per ..." | Re-trigger Greptile |
- conventional-pr stub: dual pull_request/pull_request_target triggers so fork PRs from external contributors get labeled too (the reusable workflow never checks out PR code); explicit contents:read; pinned v1.4.3. - pre-commit workflow: robust modified-files runner (null-delimited paths, deletion-only PRs handled, deleted paths filtered, no undocumented -r flag, cache keyed on config hash). - flake8 args quoted correctly (the flow-scalar form split at commas and silently reduced the select list). - hooks pinned to .github v1.4.3. TRI-1100
|
Closing: the team is moving away from centralized org-level configuration in favor of per-repository self-contained setups (see triton-inference-server/server#8897 for the first decentralized implementation). Branch retained for reference. TRI-1100 |
What does the PR do?
Aligns this repository with the org-wide setup consolidated in triton-inference-server/.github:
.pre-commit-config.yaml: shared baseline hooks, conventional-commit message validation (commit-msg stage), and the centralizedadd-licensehook from the org.githubrepository (rev: v1.4.3— excludes.github/templates, never rewrites LICENSE files).conventional-prworkflow (@v1.4.3): validates the PR title against Conventional Commits (hard gate — it becomes the squash-merge commit), derives one human-readable label per distinct type found in the title and all conforming commit subjects (e.g.ci:→CI/CD,feat:→feature,fix:→fix), enforces org-wide label colors/descriptions, detects cherry-picks, and fails if no type is derivable and no type label is assigned.Depends on triton-inference-server/.github#5 (pinned tags current:
v1.4.3— already exist, CI is green).Pros / Cons
Pros
.githubrepo) for hooks, templates, issue routing, and the PR-title workflow — one change propagates everywhere.Cons / risks
.githubrepository (tags are write-once; changes ship as a new tag + rev bump)..githubrepository to remain public.Related Issues / PRs
Related PRs:
Test plan
pre-commit validate-configpasses;pre-commit run --files <PR diff>passes locally with the centralized hooks pinned to the .github branch SHA.v1.4.3exists: the conventional-pr check validates this PR's own title and applies thecilabel.Caveats
Checklist
<commit_type>: <Title>(conventional commit)