Skip to content

ci: align pre-commit hooks and GitHub templates - #14

Closed
mc-nv wants to merge 17 commits into
mainfrom
mchornyi/TRI-1100/github-align-hooks-and-templates
Closed

mc-nv wants to merge 17 commits into
mainfrom
mchornyi/TRI-1100/github-align-hooks-and-templates

Conversation

@mc-nv

@mc-nv mc-nv commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

What does the PR do?

Aligns this repository with the org-wide setup consolidated in triton-inference-server/.github:

  • .pre-commit-config.yaml: shared baseline hooks, conventional-commit message validation (commit-msg stage), and the centralized add-license hook from the org .github repository (rev: v1.4.3 — excludes .github/ templates, never rewrites LICENSE files).
  • Pre-commit CI runs only on files modified by the PR.
  • Caller stub for the org-wide reusable conventional-pr workflow (@v1.4.3): validates the PR title against Conventional Commits (hard gate — it becomes the squash-merge commit), derives one human-readable label per distinct type found in the title and all conforming commit subjects (e.g. ci: → CI/CD, feat: → feature, fix: → fix), enforces org-wide label colors/descriptions, detects cherry-picks, and fails if no type is derivable and no type label is assigned.
  • No per-repo templates: PR templates and issue routing are inherited from the org-wide defaults in triton-inference-server/.github (issues route to the server repository).

Depends on triton-inference-server/.github#5 (pinned tags current: v1.4.3 — already exist, CI is green).

Pros / Cons

Pros

  • Single home (org .github repo) for hooks, templates, issue routing, and the PR-title workflow — one change propagates everywhere.
  • Repos carry only a config file and two small workflow stubs; no template copies to drift.
  • Commit/PR title format enforced both locally (commit-msg hook) and in CI (reusable workflow), with automatic type labels.
  • License hooks never modify LICENSE files.

Cons / risks

  • Version-pinned dependency on the org .github repository (tags are write-once; changes ship as a new tag + rev bump).
  • Template inheritance requires the org .github repository to remain public.

Related Issues / PRs

  • Resolves: TRI-1100

Related PRs:

Test plan

  • pre-commit validate-config passes; pre-commit run --files <PR diff> passes locally with the centralized hooks pinned to the .github branch SHA.
  • After .github#5 merges and v1.4.3 exists: the conventional-pr check validates this PR's own title and applies the ci label.
  • No LICENSE file content is changed by this PR.

Caveats

  • None beyond the merge-order note above.

Checklist

  • PR title follows <commit_type>: <Title> (conventional commit)
  • I ran pre-commit locally on all files changed by this PR and it passes
  • Copyright header is correct on all changed files
  • External contributors: I have read the Contribution guidelines and signed the Contributor License Agreement

Adopt the shared pre-commit baseline: two-line SPDX header, conventional
commit message validation (commit-msg stage), and the centralized
add-license / add-spdx-license hooks from developer_tools v0.2.0.
Run pre-commit CI only on files modified by the PR, and roll out the
standard issue templates and the simplified single PR template.

TRI-1100
@mc-nv mc-nv self-assigned this Jul 18, 2026
This was referenced Jul 18, 2026
Legal's Copyright / License Header Guidance specifies the SPDX form
without a comma after the year.

TRI-1100
@mc-nv
mc-nv marked this pull request as ready for review July 18, 2026 02:04
Human-readable type labels with enforced descriptions and colors.

TRI-1100
@github-actions github-actions Bot added CI/CD Continuous integration and workflow changes (ci: PRs) and removed ci labels Jul 20, 2026
@github-actions github-actions Bot added the chore Maintenance work, no production code change (chore: PRs) label Jul 20, 2026
Vinya567
Vinya567 previously approved these changes Jul 20, 2026
Deliberate maintenance bump to include the year of the current
modifications; required by the add-license hook's new staleness
check (hooks themselves never modify LICENSE files).

TRI-1100
mc-nv added 2 commits July 21, 2026 08:29
Workflow files are license-processed again (only templates excluded);
refresh the stale copyright year this repo's pre-commit workflow
carried.

TRI-1100
Grant issues:write to the labeling job (review feedback).

TRI-1100
@mc-nv
mc-nv requested a review from pskiran1 July 22, 2026 15:11
@Vinya567

Copy link
Copy Markdown

@greptileai

@greptile-apps

greptile-apps Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

Greptile Summary

This PR aligns the repository's CI configuration with the org-wide setup in triton-inference-server/.github, replacing standalone workflow steps with thin callers that delegate to pinned reusable workflows at v1.4.3.

  • conventional-pr.yml: New workflow that calls the org-wide reusable conventional-pr.yml@v1.4.3; correctly distinguishes same-repo PRs (pull_request) from fork PRs (pull_request_target) via an explicit if condition so the job never fires twice, and passes only the minimum required write permissions (pull-requests, issues).
  • pre-commit.yml: Replaces pre-commit/action with a custom run step using null-delimited output (-z / xargs -0) to safely handle file paths with spaces, adds a pre-commit cache keyed on the config file hash, and limits hook execution to files actually modified by the PR.
  • .pre-commit-config.yaml: Adds default_install_hook_types: [pre-commit, commit-msg], the conventional-pre-commit hook scoped to the commit-msg stage, and the org-wide add-license hook pinned to v1.4.3; fixes ambiguous spaces in the flake8 --extend-ignore argument.

Confidence Score: 5/5

Safe to merge — all changes are CI/tooling configuration with no application logic affected.

The changes are confined to CI workflow files, pre-commit configuration, and a copyright year update. The null-delimited git diff approach correctly handles filenames with spaces. The pull_request_target guard correctly restricts that event to fork PRs only, passes minimal write permissions, and delegates to a pinned reusable workflow that does not check out PR code. No application code is touched.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/conventional-pr.yml New thin caller workflow that delegates to the org-wide reusable conventional-pr workflow at v1.4.3; correctly gates pull_request vs pull_request_target on fork vs same-repo PRs, with write permissions scoped to PR labeling only.
.github/workflows/pre-commit.yml Replaces the pre-commit action with a custom run step using null-delimited git diff output (-z / xargs -0) to correctly handle paths with spaces, adds pre-commit cache, and limits runs to PR-modified files only.
.pre-commit-config.yaml Adds default_install_hook_types for commit-msg stage, conventional-pre-commit hook, and org-wide add-license hook pinned to v1.4.3; flake8 args reformatted to avoid ambiguous spaces around =.
LICENSE Copyright year updated from 2021 to 2021-2026; no substantive license content changed.

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub PR Event
    participant CPR as conventional-pr.yml caller
    participant OrgWF as org .github conventional-pr.yml at v1.4.3
    participant PC as pre-commit.yml
    participant PCHooks as Pre-commit Hooks

    Dev->>GH: Opens or updates PR
    GH->>CPR: pull_request same-repo OR pull_request_target fork
    CPR->>CPR: if condition routes by fork vs same-repo
    CPR->>OrgWF: uses conventional-pr.yml at v1.4.3 with write permissions
    OrgWF-->>GH: Validate PR title, derive label, detect cherry-picks
    GH->>PC: pull_request event
    PC->>PC: checkout fetch-depth 2 and restore cache
    PC->>PC: "git diff -z --diff-filter=d HEAD^1 HEAD"
    PC->>PCHooks: xargs -0 pre-commit run --files
    PCHooks-->>PC: isort, black, flake8, clang-format, codespell, add-license
    PC-->>GH: Pass or Fail
    Dev->>Dev: git commit locally
    Dev->>PCHooks: commit-msg hook fires via conventional-pre-commit
    PCHooks-->>Dev: Validates type colon title format
Loading

Reviews (2): Last reviewed commit: "ci: harden CI workflows and configs per ..." | Re-trigger Greptile

Comment thread .github/workflows/conventional-pr.yml Outdated
Comment thread .github/workflows/pre-commit.yml Outdated
- conventional-pr stub: dual pull_request/pull_request_target triggers
  so fork PRs from external contributors get labeled too (the reusable
  workflow never checks out PR code); explicit contents:read; pinned
  v1.4.3.
- pre-commit workflow: robust modified-files runner (null-delimited
  paths, deletion-only PRs handled, deleted paths filtered, no
  undocumented -r flag, cache keyed on config hash).
- flake8 args quoted correctly (the flow-scalar form split at commas
  and silently reduced the select list).
- hooks pinned to .github v1.4.3.

TRI-1100

@Vinya567 Vinya567 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mc-nv

mc-nv commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing: the team is moving away from centralized org-level configuration in favor of per-repository self-contained setups (see triton-inference-server/server#8897 for the first decentralized implementation). Branch retained for reference. TRI-1100

@mc-nv mc-nv closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance work, no production code change (chore: PRs) CI/CD Continuous integration and workflow changes (ci: PRs)

Development

Successfully merging this pull request may close these issues.

2 participants