DB seederを追加 - #2979
Open
ramdos0207 wants to merge 4 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis pull request adds a database seeding feature. It provides Make and Docker Compose execution, registers a Cobra ChangesDatabase seed command
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk remains; the change is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant Makefile
participant rootCommand
participant seedCommand
participant Database
participant FileManager
Makefile->>rootCommand: invoke backend seed
rootCommand->>seedCommand: execute seed command
seedCommand->>Database: create users, channels, and messages
seedCommand->>FileManager: create PNG stamp files
seedCommand->>Database: persist stamps and reactions
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@cmd/seed.go`:
- Around line 191-203: The seed command currently hard-codes creation of an
admin user "traq"/"traq" using file.GenerateIconFile and repo.CreateUser
(CreateUserArgs with role.Admin); change this so the admin user is only created
in non-production/dev environments and the password is not embedded: add a check
for the runtime environment (e.g., config.Environment or an
IsDevelopment/isLocal guard) and skip creating the default admin unless that
check passes OR an explicit admin password is provided via a CLI flag (e.g.,
--admin-password) or env var (e.g., ADMIN_PASSWORD); read the password from that
flag/env var and pass it into repo.CreateUser instead of the hard-coded "traq"
value, and ensure role.Admin is only assigned under the gated condition.
- Around line 406-416: The backfill can return multiple rows per channel when
several messages share MAX(created_at); change the INSERT SELECT so each channel
yields exactly one row by choosing a deterministic tie-breaker (e.g., the
largest message id among rows with the max created_at). Replace the SELECT block
with a grouped query that joins the max created_at per channel and then GROUPs
BY m.channel_id selecting MAX(m.id) AS message_id and MAX(m.created_at) AS
date_time (so each channel contributes a single (channel_id, message_id,
date_time) tuple), then keep the ON DUPLICATE KEY UPDATE as-is; refer to the
channel_latest_messages table and the messages table/columns used in this diff
and note the primary key on channel_id defined in model/messages.go for locating
where to apply the change.
- Around line 154-156: Replace the detached context creation in the RunE of the
seed command with the Cobra-provided context (use cmd.Context()) and ensure that
all GORM operations use db.WithContext(ctx) rather than raw db, and that any
helper functions invoked from RunE that perform I/O accept and propagate this
ctx; specifically update the RunE closure to obtain ctx := cmd.Context(), change
direct db.Exec/raw writes and batch inserts to db.WithContext(ctx).Exec /
db.WithContext(ctx).Create (or equivalent), and if functions called from this
block (including any wrappers around batch inserts) don't accept context, add
context.Context as the first parameter and pass ctx through. Ensure
getCLILoggers() usage remains unchanged but that logger-using calls also take
ctx where applicable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4fbe8e0e-74f6-482a-ba15-ca0ceb03f408
📒 Files selected for processing (3)
Makefilecmd/root.gocmd/seed.go
Comment on lines
+191
to
+203
| // 管理者ユーザー traq/traq の作成 | ||
| adminIconID, err := file.GenerateIconFile(ctx, fm, "traq") | ||
| if err != nil { | ||
| return fmt.Errorf("failed to generate admin icon: %w", err) | ||
| } | ||
| if u, err := repo.CreateUser(ctx, repository.CreateUserArgs{ | ||
| Name: "traq", | ||
| Password: "traq", | ||
| Role: role.Admin, | ||
| IconFileID: adminIconID, | ||
| }); err != nil { | ||
| logger.Warn("failed to create traq admin user (may already exist)", zap.Error(err)) | ||
| } else { |
Contributor
There was a problem hiding this comment.
Don't hard-code a known admin login in a general-purpose seed command.
This creates traq / traq with role.Admin against whatever database the active config points at. If seed is ever run outside an isolated local DB, it introduces a predictable privileged credential. Please gate this to dev-only environments and require the password from an explicit flag or env var instead of embedding it.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@cmd/seed.go` around lines 191 - 203, The seed command currently hard-codes
creation of an admin user "traq"/"traq" using file.GenerateIconFile and
repo.CreateUser (CreateUserArgs with role.Admin); change this so the admin user
is only created in non-production/dev environments and the password is not
embedded: add a check for the runtime environment (e.g., config.Environment or
an IsDevelopment/isLocal guard) and skip creating the default admin unless that
check passes OR an explicit admin password is provided via a CLI flag (e.g.,
--admin-password) or env var (e.g., ADMIN_PASSWORD); read the password from that
flag/env var and pass it into repo.CreateUser instead of the hard-coded "traq"
value, and ensure role.Admin is only assigned under the gated condition.
Contributor
Author
There was a problem hiding this comment.
まぁそうだが、初回起動前にmake seedした場合にしか起こらない問題で、そして初回起動時にtraqユーザーが作成されるのは既存の問題なので、このPRではそのままにする
Contributor
There was a problem hiding this comment.
@ramdos0207 承知しました。この PR では変更しないという判断を尊重します。
make seed を初回起動前に実行した場合の traq 管理者作成は、既存の初回起動時の挙動と同じ問題として扱う、という前提ですね。必要であれば、この既存挙動を対象にしたフォローアップ Issue を作成できます。
🐇 ˘︵˘
✏️ Learnings added
Learnt from: ramdos0207
Repo: traPtitech/traQ PR: 2979
File: cmd/seed.go:191-203
Timestamp: 2026-08-15T14:35:32.414Z
Learning: In the traQ repository, running `make seed` before the first startup can create the default `traq` administrator. This is equivalent to existing first-startup behavior, where the `traq` user is also created. Remediation of the predictable default administrator credential is intentionally out of scope for pull request `#2979` and should be handled as a separate existing-behavior concern.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
You are interacting with an AI system.
YuHima03
self-requested a review
July 4, 2026 07:15
YuHima03
removed their request for review
August 10, 2026 11:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本番と同じぐらいの重さにするためのseederを追加
Summary by CodeRabbit
seedcommand for populating the database with synthetic test data.