feat: release時にmanifestのRenovateを回すようにする - #1047
Open
renkonmaster wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughGitHub Actionsの Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/release.yaml (1)
74-74:releaseジョブへの依存も検討を現在は
needs: [image]のみで、releaseジョブ（GitHub Releaseの作成）が成功しているかどうかに関わらず、imageジョブが成功すればRenovateが起動します。PR目的が「Release時にRenovateを回す」であれば、releaseジョブの成功も条件に含めることを検討してください。♻️ 修正案
- needs: [image] + needs: [image, release]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yaml at line 74, The job currently lists only needs: [image], so Renovate can run even if the release job failed; update the job's needs array to include the release job as a dependency (e.g., change needs: [image] to needs: [image, release]) so that the job waits for both the image and release jobs to succeed; locate the job definition in release.yaml and modify the needs key accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release.yaml:
- Around line 76-78: Remove the unnecessary elevated workflow permission by
deleting the "actions: write" entry from the permissions block (leave "contents:
read"), since the job overrides GITHUB_TOKEN with env GITHUB_TOKEN: ${{
secrets.PAT_TOKEN }} and therefore does not use the built-in token; update the
permissions stanza (referencing the permissions: block and the actions: write
symbol) to follow least-privilege.
---
Nitpick comments:
In @.github/workflows/release.yaml:
- Line 74: The job currently lists only needs: [image], so Renovate can run even
if the release job failed; update the job's needs array to include the release
job as a dependency (e.g., change needs: [image] to needs: [image, release]) so
that the job waits for both the image and release jobs to succeed; locate the
job definition in release.yaml and modify the needs key accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release時にmanifestのRenovateを動かすようにGHAを書いた
Summary by CodeRabbit
リリースノート