mass asignment対策 - #14
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #5 by preventing mass assignment in the PATCH /api/videos/{id} endpoint, ensuring clients can only update intended editable fields rather than arbitrarily overwriting video metadata.
Changes:
- Added strict request-body validation and an allowlist for updatable fields (
title,description) inpatchVideo. - Updated OpenAPI schema to disallow empty bodies and unknown properties for the patch request.
- Added regression tests to verify protected fields cannot be modified and invalid payloads are rejected.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
controllers/api_videos.cpp |
Replaces updateByJson with explicit allowlisted updates and validates patch request JSON shape/types. |
docs/openapi.yml |
Tightens PATCH request schema (minProperties: 1, additionalProperties: false) to match new server-side validation. |
test/controllers.cpp |
Adds tests covering mass-assignment attempts and invalid PATCH bodies/types returning 400 and not mutating stored data. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #5