feat:それっぽいルーム表示カード - #58
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Issue #32 に対応して、ポータル内の部屋一覧で表示する「部屋カード(RoomCard)」コンポーネントを新規追加し、fixture データで見た目と動作(開閉・開始アクション)を確認できるようにする PR です。
Changes:
RoomCardコンポーネントを追加し、開閉可能な詳細表示と開始ボタンのイベント送出を実装- Histoire 用の story と、開閉・emit を確認するユニットテストを追加
- トグルアイコン用に Material Symbols Outlined フォントを読み込む CSS を追加
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| client/src/RoomCard.vue | Headless UI の Disclosure を使った部屋カード UI と start イベントを追加 |
| client/src/RoomCard.story.vue | fixture を使った Closed/Open の表示確認用 story を追加 |
| client/src/assets/main.css | Material Symbols Outlined のフォント読み込みを追加 |
| client/src/tests/RoomCard.spec.ts | 開閉動作と start emit を検証するテストを追加 |
Suppressed comments (1)
client/src/tests/RoomCard.spec.ts:30
- ここも
wrapper.get('button')だと将来 DOM 内のボタンが増えた際に違う要素をクリックしてしまう可能性があります。ヘッダー (.room-card__header) を明示的にクリックするようにしてください。
await wrapper.get('button').trigger('click')
expect(wrapper.get('.room-card__description').text()).toBe(room.description)
await wrapper.get('button').trigger('click')
expect(wrapper.find('.room-card__body').exists()).toBe(false)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kaomojikun5
requested changes
Aug 26, 2026
kaomojikun5
left a comment
Contributor
There was a problem hiding this comment.
2点修正お願いします。
それとfigmaにあるやつみたいにライトテーマに合わせてくれると嬉しいです。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#32
データの受け渡しがよくわかんなかった