fix: schema-qualify DROP INDEX for non-default schemas - #2289
Open
AdhamKhalifa wants to merge 1 commit into
Open
AdhamKhalifa wants to merge 1 commit into
AdhamKhalifa wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Schema-qualify
DROP INDEXon PostgreSQL and Oracle soRemoveIndexand partialRemoveConstraintcan drop indexes that live outside the connectionsearch_path.remove_index()already passed a schema-qualified{table}intoDROP INDEX "{name}", but the template has no{table}placeholder, sostr.format()discarded it. Create still used{table_name}via_qualify_table_name(), which is why the index existed and the drop then failed withindex "..." does not exist.Name-only dialects now qualify the index identifier itself (
DROP INDEX "schema"."name"). MySQL and MSSQL keep their table-scopedDROP INDEX ... ON {table}form.Motivation and Context
Fixes #2288.
How Has This Been Tested?
make checkmake test(sqlite in-memory): 1959 passed, 148 skipped, 2 xfailedChecklist:
Made with Cursor