Handle unwinding from Box::new - #837
Merged
Merged
Conversation
|
|
||
| impl From<Vec<u8>> for Bytes { | ||
| fn from(vec: Vec<u8>) -> Bytes { | ||
| let shared = Box::new(MaybeUninit::<Shared>::uninit()); |
There was a problem hiding this comment.
This seems to go against the line
// Avoid an extra allocation if possible
Member
Author
There was a problem hiding this comment.
Good point. I wanted to move it before the ManuallyDrop line. Fixed.
seanmonstar
approved these changes
Jul 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few cases where a panic from
Box::newhas incorrect behavior because it runs the destructor of the argument passed tonew. They are fixed by ensuring that the allocation is performed before creating the value to be stored in the box.Note that the default configuration is to abort on allocation failure, but it's possible to configure the allocator so that OOM results in panic instead of abort.
Fixes: #836