stm32u5: set panic resources - #4972
Open
alexandruradovici wants to merge 3 commits into
Open
Conversation
bradjc
reviewed
Jul 22, 2026
Comment on lines
+386
to
389
| } else { | ||
| let _ = writer.write_str("\r\nNo loaded processes\r\n"); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I'm not sure we need to print that there are no processes here, as the caller can/should check instead.
Contributor
Author
There was a problem hiding this comment.
We did no check the process and thought that the panic print was stuck. While for UART panic this is usually not the case (being stuck), USB CDC panics could actually get stuck.
Comment on lines
363
to
365
| @@ -353,21 +365,27 @@ pub unsafe fn panic_process_info<PP: ProcessPrinter, W: Write>( | |||
| process_printer: Option<&'static PP>, | |||
Contributor
There was a problem hiding this comment.
I wonder if instead we could make this not an option and have the caller have to decide what to do.
Contributor
Author
There was a problem hiding this comment.
Works for me, this would make the caller check. I modified it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request:
We forgot to set the
PANIC_RESOURCESfields for the stm32u5 board and the panic handler was not printing the correct information. Initially we thought it was a UART issue, just to figure out that we forgot to initialise the fields.This PR adds some messages that clearly state of those fields are not available.
Testing Strategy
This pull request was tested by @alexandruradovici.
TODO or Help Wanted
N/A
Checklist
make prepush.PR Contents
Documentation
/docsand the Book.AI Use