Skip to content

Honor HTTP header 'X-Real-IP' when available #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pini-gh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Honor HTTP header 'X-Real-IP' when available #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/prod.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ config :tmate, :websocket, Keyword.merge(websocket_ranch_opts,
cowboy_opts: %{
compress: true,
proxy_header: System.get_env("USE_PROXY_PROTOCOL") == "1"},
base_url: System.get_env("WEBSOCKET_BASE_URL")
base_url: System.get_env("WEBSOCKET_BASE_URL"),
trust_x_real_ip: System.get_env("TRUST_X_REAL_IP") == "1"
)

config :tzdata, :autoupdate, :disabled
Expand Down
4 changes: 4 additions & 0 deletions lib/tmate/ws_api/websocket.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,12 @@ defmodule Tmate.WsApi.WebSocket do
{mode, session} ->
case Tmate.Session.ws_verify_auth(session) do
:ok ->
trust_x_real_ip = Application.get_env(:tmate, :websocket)[:trust_x_real_ip]
ip = case req do
%{proxy_header: %{src_address: ip}} -> ip
%{headers: %{"x-real-ip" => ipstring}} when trust_x_real_ip ->
{_, ip} = :inet.parse_address(ipstring |> to_charlist)
ip
%{peer: {ip, _port}} -> ip
end
ip = :inet_parse.ntoa(ip) |> to_string
Expand Down