Repository navigation
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
法典审查摘要此评论显示了针对此拉取请求的最新法典审查活动。
ℹ️ 关于 GitHub 中的 Codex您的团队已设置 Codex 来审查此存储库中的拉取请求。 当您
当任何审查正在进行时，Codex 会以 👀 做出反应，如果有建议则进行评论，并在所有审查结束且没有发现结果时以 👍 做出反应。 </详情> |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c05aa771c0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
5c18b55 to
e23e11a
Compare
Add a collapse arrow to the bottom-right of the input field's button bar (the clear button sits to its left), matching the result view's arrow. When collapsed, the text area is hidden and only the button bar stays visible; typing or pasting while collapsed expands it again. The collapsed state is persisted per window type, but only for select-text translation: auto select, shortcut select, and invoke queries from PopClip / macOS Services via URL scheme. Other actions (input, OCR, pasteboard, etc.) always start expanded, and toggling there only lasts for the current session. - EZQueryView reports its height via heightOfQueryView so a collapsed field no longer grows when a new window is shown with selected text, and the scroll view is not pinned to the top while collapsed to avoid constraint conflicts with the button bar. - EZWindowManager updates the action type before computing the window location, so a collapsed-state height change does not shift the window's top edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Query in App on the current or a pinned window calls startQueryText:actionType: directly, so an invoke query did not restore the saved collapsed state, and swapping translation languages re-queried as input query without expanding the field. Apply the collapsed state there when the action type changes, keeping session-only toggles for same-type re-queries. OCR actions keep the current collapsed state, both when the window is shown and after OCR finishes. The OCR loading view keeps two constraint sets: anchored to the text view when expanded, and placed in the button bar right after the copy button, or the detect language button when it is visible, when collapsed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
e23e11a to
5af4fa9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5af4fa9dd8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24a0a9de83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The dev merge brought in tisfeng#1327, which dropped the animated row-update API in favor of immediate row layout with window-only animation. Use updateQueryCell for both input-field collapse paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 196009b513
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
背景 / Context
When Window Configuration → Show Input Text Field is enabled, the input (source text) block cannot be collapsed. For users who mostly translate selected text, the source text is already visible in the original app, so the huge input block takes up window space for no benefit.
Goal: let users collapse the input block the same way as result blocks, and remember that choice for select-text translation.
变更内容 / Changes
Collapse control: added an arrow button at the bottom-right of the input block's button bar. The clear button now sits to its left. It uses the same
arrow-down/arrow-lefticons and the existingshow/hidetooltips as the result view, so no new localized strings are needed. When collapsed, the text area is hidden and only the button bar remains.Persistence scope: the collapsed state is saved per window type in Defaults (
EZConfiguration_kInputFieldCollapsedKey_<windowType>), but only for select-text translation:-q)Other actions (input translate, OCR, pasteboard translate, etc.) always open the block expanded. Toggling it there lasts only for the current session and does not change the saved preference.
Auto-expand: typing or pasting while the block is collapsed expands it, so input is never invisible. At that point the action type has become an input query, so the saved select-text preference is not overwritten.
Layout fixes:
EZQueryViewreports its row height viaheightOfQueryView, which takes the collapsed state into account. Previously the collapsed block grew to the text height when a new window opened with selected text.Window position:
EZWindowManagernow updates the action type before computing the floating window location, so a height change from restoring the collapsed state does not shift the window's top edge.Files:
EZQueryView.{h,m},EZBaseQueryViewController.m,EZWindowManager.m,Configuration+Extension.swift,Defaults.Keys+Extension.swift.关联 Issue / Linked Issues
Didn't found
验证 / Verification
xcodebuild build(Debug, Xcode 26.3, macOS 15.8.1): succeeded. On the local machine, the asset catalog.iconexport step fails withIcon export exited with status 255, an environment issue unrelated to this change. The build was therefore run with'EXCLUDED_SOURCE_FILE_NAMES=*.icon' ASSETCATALOG_COMPILER_APPICON_NAME=AppIcon. No new warnings in changed files.git diff --check: passed.截图 / Screenshots
Before
After
