Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkerInfo.postTask()successfully posted a taskpostMessage()synchronously rejects an unserializable taskProblem
When a worker becomes available,
_onWorkerAvailable()removes one task from the queue and returns after callingpostTask(). IfpostMessage()throws,postTask()rejects that task but does not occupy the worker. The scheduler still returns, leaving the worker idle and later queued tasks stuck indefinitely.This surfaced while removing a redundant structured-clone preflight from Rspack's parallel loader path. A non-cloneable loader input correctly rejected, but the shared pool stopped scheduling later builds.
The fix keeps the task-level rejection and continues the existing scheduling loop only when posting failed. Successful task dispatch remains unchanged and does not add a preflight clone.
Validation
vitest run— 99 tests passedtsc --noEmiteslint --max-warnings=0tsdown