Skip to content

fix(ci): align dep-sim calibration with the post-git-shed kernel floor - #5556

Closed
YellowSnnowmann wants to merge 2 commits into
tinyhumansai:mainfrom
YellowSnnowmann:fix/ci-dep-sim-expect-names
Closed

fix(ci): align dep-sim calibration with the post-git-shed kernel floor#5556
YellowSnnowmann wants to merge 2 commits into
tinyhumansai:mainfrom
YellowSnnowmann:fix/ci-dep-sim-expect-names

Conversation

@YellowSnnowmann

@YellowSnnowmann YellowSnnowmann commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • CI Lite's Feature-Gate Smoke (gates off) lane fails on main: the dep-sim calibration guard asserts 281 dependency names while the no-default + flows profile now resolves 279.
  • chore(deps): move git2 ownership into tinycortex #5544 (move-git-to-tinycortex) shed git2 / libgit2-sys / libz-sys behind the memory-git gate — the documented kernelization target of 279 names / 2 native builds.
  • scripts/kernel-floor.limits was updated to 279, but the dep-sim --expect-names call in ci-lite.yml was left at 281, breaking the "calibration must equal kernel-floor.sh" invariant.
  • Lower --expect-names 281279. Workflow-only; no dependency or code change.

Problem

Solution

  • Set scripts/dep-sim.py --cut-nothing --expect-names to 279 in .github/workflows/ci-lite.yml, matching the baseline dep-sim itself measures (297 packages / 279 names / 2 native: libsqlite3-sys, ring) and the flows:297:279:2 entry in scripts/kernel-floor.limits. This restores the documented invariant dep-sim.py --cut-nothing == kernel-floor.sh.
  • Nothing is masked: the 2-name drop is the intended git-cohort shed from chore(deps): move git2 ownership into tinycortex #5544, not a missing dependency. check-kernel-floor.sh independently passes at 279/279.

Submission Checklist

  • Tests added or updated — N/A: CI-workflow calibration constant. Correctness is enforced by the smoke lane itself — dep-sim --cut-nothing is cross-checked against check-kernel-floor.sh, which already passes at 279.
  • Diff coverage ≥ 80%N/A: no application code changed (single-line workflow YAML).
  • Coverage matrix updated — N/A: no feature rows added/removed/renamed.
  • All affected feature IDs listed — N/A: no feature behaviour changes.
  • No new external network dependencies — N/A: none introduced; the dependency graph is unchanged.
  • Manual smoke checklist updated — N/A: no release-cut surface touched.
  • Linked issue closed via Closes #NNNN/A: no tracking issue; this fixes a main CI regression introduced alongside chore(deps): move git2 ownership into tinycortex #5544.

Impact

  • Restores green CI Lite on main and unblocks all open PRs currently red on Feature-Gate Smoke. No runtime/platform/performance/security/compatibility impact — the resolved dependency set is unchanged; only the assertion constant is corrected.

Related


AI Authored PR Metadata (required for Codex/Linear PRs)

  • N/A — human-authored.

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: fix/ci-dep-sim-expect-names
  • Commit SHA: 4701d59

Validation Run

  • pnpm --filter openhuman-app format:checkN/A: no frontend files changed.
  • pnpm typecheckN/A: no TS changed.
  • Focused tests — N/A: workflow-only change.
  • Rust fmt/check (if changed) — N/A: no Rust changed.
  • Tauri fmt/check (if changed) — N/A: no Rust changed.

Validation Blocked

  • command: N/A
  • error: N/A
  • impact: N/A

Behavior Changes

  • Intended behavior change: CI calibration guard now expects 279 names (matches actual), so the Feature-Gate Smoke lane passes.
  • User-visible effect: none (CI-only).

Parity Contract

  • Legacy behavior preserved: yes — dependency graph unchanged; only the expected-count constant is corrected.
  • Guard/fallback/dispatch parity checks: dep-sim --cut-nothing now equals check-kernel-floor.sh (both 279).

Duplicate / Superseded PR Handling

  • Duplicate PR(s): none
  • Canonical PR: this
  • Resolution: N/A

Summary by CodeRabbit

  • Tests
    • Updated the dependency simulation calibration check to reflect the current expected results.
    • This keeps automated validation aligned with the latest dependency data and helps ensure continuous integration reports accurate outcomes.

The Feature-Gate Smoke lane fails on main. The dep-sim calibration guard
still asserts 281 dependency names, but tinyhumansai#5544 (move-git-to-tinycortex) moved
git2/libgit2-sys/libz-sys behind the memory-git gate, dropping the
no-default + flows profile to 279 names / 2 native builds — the documented
kernelization target. scripts/kernel-floor.limits was updated to 279; this
one call site was left at 281, so `dep-sim --cut-nothing --expect-names` no
longer equals kernel-floor.sh, the calibration invariant it exists to hold.

Lower the expectation to 279 to match the baseline dep-sim itself measures
(297 packages / 279 names / 2 native: libsqlite3-sys, ring) and the
kernel-floor ratchet. Workflow-only change; no dependency or code change.
@YellowSnnowmann
YellowSnnowmann requested a review from a team August 14, 2026 12:16
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d7052807-02cd-463b-8736-0497582f24bf

📥 Commits

Reviewing files that changed from the base of the PR and between fc33103 and 4701d59.

📒 Files selected for processing (1)
  • .github/workflows/ci-lite.yml

📝 Walkthrough

Walkthrough

The CI workflow updates the dependency simulator calibration check to expect 279 names instead of 281.

Changes

Dependency simulator calibration

Layer / File(s) Summary
Update calibration guard
.github/workflows/ci-lite.yml
The guard now expects 279 dependency simulator names.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4701d

This CI-only change corrects the dependency-name calibration from 281 to 279 without changing the resolved dependency graph or product behavior; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: senamakel

Poem

A rabbit checked the names in line,
Two fewer hops now make them fine.
The CI gate counts with care,
279 names are there.
“Green paws!” the rabbit sings.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the CI calibration update and its alignment with the kernel-floor baseline.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Aug 14, 2026

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0112 · 26,406 in / 987 out · 2,688 cached (10%) · openrouter/openai/text-embedding-3-small, deepseek/deepseek-v4-pro-0813 · 37 embedded
critique:    $0.0048 · 11,282 in / 342 out · 896 cached (8%)    · deepseek/deepseek-v4-pro-0813
security:    $0.0047 · 11,261 in / 219 out · 896 cached (8%)    · deepseek/deepseek-v4-pro-0813
description: $0.0017 · 3,863 in  / 426 out · 896 cached (23%)   · deepseek/deepseek-v4-pro-0813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant