fix(ci): align dep-sim calibration with the post-git-shed kernel floor - #5556
fix(ci): align dep-sim calibration with the post-git-shed kernel floor#5556YellowSnnowmann wants to merge 2 commits into
Conversation
The Feature-Gate Smoke lane fails on main. The dep-sim calibration guard still asserts 281 dependency names, but tinyhumansai#5544 (move-git-to-tinycortex) moved git2/libgit2-sys/libz-sys behind the memory-git gate, dropping the no-default + flows profile to 279 names / 2 native builds — the documented kernelization target. scripts/kernel-floor.limits was updated to 279; this one call site was left at 281, so `dep-sim --cut-nothing --expect-names` no longer equals kernel-floor.sh, the calibration invariant it exists to hold. Lower the expectation to 279 to match the baseline dep-sim itself measures (297 packages / 279 names / 2 native: libsqlite3-sys, ring) and the kernel-floor ratchet. Workflow-only change; no dependency or code change.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI workflow updates the dependency simulator calibration check to expect 279 names instead of 281. ChangesDependency simulator calibration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This CI-only change corrects the dependency-name calibration from 281 to 279 without changing the resolved dependency graph or product behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0112 · 26,406 in / 987 out · 2,688 cached (10%) · openrouter/openai/text-embedding-3-small, deepseek/deepseek-v4-pro-0813 · 37 embedded
critique: $0.0048 · 11,282 in / 342 out · 896 cached (8%) · deepseek/deepseek-v4-pro-0813
security: $0.0047 · 11,261 in / 219 out · 896 cached (8%) · deepseek/deepseek-v4-pro-0813
description: $0.0017 · 3,863 in / 426 out · 896 cached (23%) · deepseek/deepseek-v4-pro-0813
Summary
main: the dep-sim calibration guard asserts 281 dependency names while theno-default + flowsprofile now resolves 279.git2/libgit2-sys/libz-sysbehind thememory-gitgate — the documented kernelization target of 279 names / 2 native builds.scripts/kernel-floor.limitswas updated to279, but thedep-sim --expect-namescall inci-lite.ymlwas left at281, breaking the "calibration must equalkernel-floor.sh" invariant.--expect-names281→279. Workflow-only; no dependency or code change.Problem
Every PR targeting
main(and pushes tomainitself) now fails the Feature-Gate Smoke lane. The job's tests all pass; it exits 1 on the calibration step:The failure is independent of PR content — it blocks in-flight PRs whose diffs touch no dependencies at all (e.g. fix(voice): make the deadline line a neutral acknowledgement #5549, fix(voice): stop the directive turning an announcement into the answer #5550, both voice-only).
Solution
scripts/dep-sim.py --cut-nothing --expect-namesto279in.github/workflows/ci-lite.yml, matching the baseline dep-sim itself measures (297 packages / 279 names / 2 native:libsqlite3-sys,ring) and theflows:297:279:2entry inscripts/kernel-floor.limits. This restores the documented invariantdep-sim.py --cut-nothing==kernel-floor.sh.check-kernel-floor.shindependently passes at 279/279.Submission Checklist
N/A: CI-workflow calibration constant. Correctness is enforced by the smoke lane itself —dep-sim --cut-nothingis cross-checked againstcheck-kernel-floor.sh, which already passes at 279.N/A: no application code changed (single-line workflow YAML).N/A: no feature rows added/removed/renamed.N/A: no feature behaviour changes.N/A: none introduced; the dependency graph is unchanged.N/A: no release-cut surface touched.Closes #NNN—N/A: no tracking issue; this fixes amainCI regression introduced alongside chore(deps): move git2 ownership into tinycortex #5544.Impact
mainand unblocks all open PRs currently red on Feature-Gate Smoke. No runtime/platform/performance/security/compatibility impact — the resolved dependency set is unchanged; only the assertion constant is corrected.Related
Follows chore(deps): move git2 ownership into tinycortex #5544 (move-git-to-tinycortex), which performed the git-cohort shed that moved the baseline to 279.
Unblocks fix(voice): make the deadline line a neutral acknowledgement #5549, fix(voice): stop the directive turning an announcement into the answer #5550 (and any other open PR failing Feature-Gate Smoke).
Closes: N/A
Follow-up PR(s)/TODOs: none
AI Authored PR Metadata (required for Codex/Linear PRs)
N/A— human-authored.Linear Issue
Commit & Branch
fix/ci-dep-sim-expect-namesValidation Run
pnpm --filter openhuman-app format:check—N/A: no frontend files changed.pnpm typecheck—N/A: no TS changed.N/A: workflow-only change.N/A: no Rust changed.N/A: no Rust changed.Validation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
Parity Contract
dep-sim --cut-nothingnow equalscheck-kernel-floor.sh(both 279).Duplicate / Superseded PR Handling
Summary by CodeRabbit