chore(deps): move git2 ownership into tinycortex - #5544
2 findings
The change correctly removes the direct git2 dependency and retargets the test to tinycortex's re-export, but it omits required companion artifacts: the Cargo.lock update and the vendor submodule advancements. As-is, the PR will not build or pass the kernel-floor check that the description claims. Code retrieval was unavailable (model: openrouter embeddings returned 402 Payment Required: {"error":{"message":"Insufficient credits. Add more using https://openrouter.ai/settings/credits","code":402,"metadata":{"limit_source":"openrouter_credits","remedy_hint":"Add credits at https://openrouter.ai/settings/credits, or lower max_tokens / prompt size to fit your remaining balance."}}}), so this review saw the diff alone.
| Finding | Where | |
|---|---|---|
 |
Commit the Cargo.lock update required by the dependency change | (pull request description) |
|
Include the vendor submodule updates the test depends on | (pull request description) |
 Commit the Cargo.lock update required by the dependency change
(pull request description)
[RULE] missing-lockfile-update
Removing the git2 dependency and dropping dep:git2 from the memory-git feature changes the crate's dependency graph, so Cargo.lock must be regenerated and committed. The diff contains no Cargo.lock change. CI runs with --locked will fail with an out-of-date lockfile, and even local non-locked builds silently mutate the lockfile. Run cargo check --no-default-features --features memory-git and commit the resulting lockfile update.
 Include the vendor submodule updates the test depends on
(pull request description)
[RULE] missing-submodule-update
The test now uses tinycortex::git2::Repository::open, which only exists after tinycortex#147 lands. The diff advances no vendor gitlink, so with the current vendored tinycortex this will not compile: cargo test --no-default-features --features memory-git --test memory_artifacts_e2e will fail to find tinycortex::git2. The scripts/kernel-floor.limits change to flows:297:279:2 likewise assumes the submodule bumps' -6 package shed; without them the ratchet will fail because the actual count remains 303/281/2. Add the vendor/tinycortex and vendor/tinymemory gitlink updates to the branch before merging.
