all: modernize#5498
Merged
Merged
Conversation
eliasnaur
approved these changes
Jul 6, 2026
eliasnaur
left a comment
eliasnaur
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this. Feel free to ignore the few nits below.
aykevl
approved these changes
Jul 6, 2026
aykevl
left a comment
aykevl
left a comment
Member
There was a problem hiding this comment.
Thank you so much for doing this!
Member
|
Thanks for working on this one @jakebailey and to @eliasnaur and @aykevl for review. Now squash/merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This runs https://pkg.go.dev/golang.org/x/tools@v0.47.0/go/analysis/passes/modernize on the repo, applying quite a few fixes.
I started because I noticed a
path := pathin some code I was touching, then just decided to run the full suite.(A future version of go will have this builtin as
go fix.)